This repository was archived by the owner on Aug 19, 2025. It is now read-only.
Ensure __getattr__ matches __getitem__'s behaviour#507
Open
circlingthesun wants to merge 1 commit intoencode:masterfrom
Open
Ensure __getattr__ matches __getitem__'s behaviour#507circlingthesun wants to merge 1 commit intoencode:masterfrom
circlingthesun wants to merge 1 commit intoencode:masterfrom
Conversation
The `__getitem__` function does extra deserialisation that's not happening in __getattr__. As an example referencing a JSONB field with __getitem__ gets you a `dict` whereas `__getattr__` results in a `str`. This PR aligns their behaviour.
|
Also, the current This can be also fixed in this PR by doing the following (Else def __getattr__(self, name: str) -> typing.Any:
try:
return self.__getitem__(name)
except KeyError as e:
raise AttributeError(e.args[0]) from e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
__getitem__function does extra deserialisation that's not happening in getattr. As an example referencing a JSONB field with getitem gets you adictwhereas__getattr__results in astr. This PR aligns their behaviour.