feat(adapter): implement FilterTxs

[julienrbrt]

Closes: #346

[gemini-code-assist]

Summary of Changes

Hello @julienrbrt, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the core implementation of the FilterTxs function within the Adapter. This enhancement is critical for managing the inclusion of transactions into blocks by providing a mechanism to validate, size, and gas-check transactions, especially when dealing with a mix of mempool and force-included transactions. It ensures that only valid and appropriately sized/gassed transactions are processed, optimizing block construction and resource utilization.

Highlights

• Implemented FilterTxs function: The FilterTxs function within the Adapter now provides comprehensive logic for filtering transactions based on various criteria.
• Differentiated transaction handling: The filtering process distinguishes between transactions from the mempool (already validated) and force-included transactions, applying CheckTx only when necessary.
• Applied byte and gas limits: Transactions are now filtered and postponed based on maxBytes and maxGas limits, ensuring that block capacity is respected.
• Categorized transaction statuses: Each transaction is assigned a FilterStatus of FilterOK, FilterRemove (for invalid or oversized/over-gassed transactions), or FilterPostpone (for transactions exceeding cumulative limits).

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• pkg/adapter/adapter.go
  • Implemented the FilterTxs function.
  • Added logic to handle transaction filtering based on maxBytes and maxGas.
  • Included conditional CheckTx calls for force-included transactions.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request implements the "FilterTxs" function. A critical security vulnerability has been identified: the filtering logic is entirely bypassed when "hasForceIncludedTransaction" is false, leading to blocks exceeding gas limits and potentially causing a Denial of Service (DoS) and halting the chain. It is crucial to enforce block limits consistently, even for transactions originating solely from the mempool.