Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
i added PySide6 and PyQt6 support to the
-qt-supportcommand line argument. The changes from qt5 to qt6 where quite minimal so I mostly added imports. The only relevant breaking change is the deprecation (PySide6) / removal (PyQt6) ofexec_()in favor ofexec()inQThread/QCoreApplication.PyQt5 and PySide2 support both, so once Qt4 support is dropped, that additional check could be removed.
test_case_qthread4is failing for me with PySide2 and PySide6, so i dont think its actually related to my change. It works with PyQt6 though (only tested with those three).I did not touch any of that pydev_ipython stuff, because i never really used IPython, but I had a quick look at the upstream sources in the IPython repo and they changed some other things, so it might be worth importing those again.