Skip to content

[DevTools] Separate breadcrumbs with »#35705

Merged
eps1lon merged 4 commits intofacebook:mainfrom
eps1lon:sebbie/right-double-angle-quote
Feb 5, 2026
Merged

[DevTools] Separate breadcrumbs with »#35705
eps1lon merged 4 commits intofacebook:mainfrom
eps1lon:sebbie/right-double-angle-quote

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Feb 5, 2026

Summary

Stacked on #35700

This avoids a common confusion with the Suspense breadcrumbs by making it clearer that this is a hierarchy. Applied the same styling to the Owner Stack in the Components tab.

localhost_8080_ (5)

Required a refactor how we measure the combined item size which isolates individual Components better and actually uses ResizeObserver instead of just recalculating when the number of owners changes.

How did you test this change?

CleanShot.2026-02-05.at.18.01.17.mp4

@meta-cla meta-cla bot added the CLA Signed label Feb 5, 2026
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Feb 5, 2026
Comment on lines -139 to -142
// If we're already overflowing, then we don't need to re-measure items.
// That's because once the owners stack is open, it can only get larger (by drilling in).
// A totally new stack can only be reached by exiting this mode and re-entering it.
if (elementsBarRef.current === null || isOverflowing) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need the isOverflow check anymore since we don't have the resize observe connected when we're overlfow.

@eps1lon eps1lon marked this pull request as ready for review February 5, 2026 17:14
@eps1lon eps1lon requested a review from hoxyq February 5, 2026 17:14
@eps1lon eps1lon force-pushed the sebbie/right-double-angle-quote branch from 3b9fc4b to dec687f Compare February 5, 2026 22:34
@eps1lon eps1lon merged commit 1c66ac7 into facebook:main Feb 5, 2026
234 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants