[DevTools] Separate breadcrumbs with »#35705
Merged
eps1lon merged 4 commits intofacebook:mainfrom Feb 5, 2026
Merged
Conversation
eps1lon
commented
Feb 5, 2026
Comment on lines
-139
to
-142
| // If we're already overflowing, then we don't need to re-measure items. | ||
| // That's because once the owners stack is open, it can only get larger (by drilling in). | ||
| // A totally new stack can only be reached by exiting this mode and re-entering it. | ||
| if (elementsBarRef.current === null || isOverflowing) { |
Collaborator
Author
There was a problem hiding this comment.
We don't need the isOverflow check anymore since we don't have the resize observe connected when we're overlfow.
hoxyq
approved these changes
Feb 5, 2026
3b9fc4b to
dec687f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #35700
This avoids a common confusion with the Suspense breadcrumbs by making it clearer that this is a hierarchy. Applied the same styling to the Owner Stack in the Components tab.
Required a refactor how we measure the combined item size which isolates individual Components better and actually uses ResizeObserver instead of just recalculating when the number of owners changes.
How did you test this change?
CleanShot.2026-02-05.at.18.01.17.mp4