fix: update NS information about ICD and ECD trains#688
Open
fix: update NS information about ICD and ECD trains#688
Conversation
lenderom
added
content
|
Hi there! 👋 Thank you for your contribution to the FIP Guide! 🚀 Checklist before merging:
|
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
Comment on lines
+6
to
+13
| If you get $ARGUMENTS: | ||
| The $ARGUMENTS are the pages which should be translated into the other languages. | ||
| If the page already exists, only translate the added or changed parts. If the translated page doesn't exist yet, create it. | ||
|
|
||
| If you don't get $ARGUMENTS: | ||
| Find out which changes need to be translated using the Git version control system. | ||
| For this do a diff of the branch against the main branch and also check for not yet commited local changes. | ||
| If the page already exists, only translate the added or changed parts. If the translated page doesn't exist yet, create it. |
Member
There was a problem hiding this comment.
This doesn't work as $ARGUMENTS is replaced by the argument.
So the prompt itself would be "If you get :" if no argument is provided.
We could create two commands (one for page translation, one for auto translation). Disadvantage: We have to maintain the rules in two different places.
The alternative would be to modify the prompt like this:
Suggested change
| If you get $ARGUMENTS: | |
| The $ARGUMENTS are the pages which should be translated into the other languages. | |
| If the page already exists, only translate the added or changed parts. If the translated page doesn't exist yet, create it. | |
| If you don't get $ARGUMENTS: | |
| Find out which changes need to be translated using the Git version control system. | |
| For this do a diff of the branch against the main branch and also check for not yet commited local changes. | |
| If the page already exists, only translate the added or changed parts. If the translated page doesn't exist yet, create it. | |
| The following line provides user-provided input. If no arguments are passed, the line will be `ARGUMENTS:`. If arguments are passed, you'll see them after `ARGUMENTS:` | |
| ARGUMENTS: $ARGUMENTS | |
| If ARGUMENTS are passed: | |
| The ARGUMENTS are the pages which should be translated into the other languages. | |
| If the page already exists, only translate the added or changed parts. If the translated page doesn't exist yet, create it. | |
| If you don't get ARGUMENTS: | |
| Find out which changes need to be translated using the Git version control system. | |
| For this do a diff of the branch against the main branch and also check for not yet commited local changes. | |
| If the page already exists, only translate the added or changed parts. If the translated page doesn't exist yet, create it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the information for the NS ICD and ECD