cli: start/stop storage modules in ctl commands - Fixes #815 #816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start LifetimeModule instances when running CLI subcommands that operate on storage/auth DBs, and stop them on Close(). This fixes imap-acct crashes due to uninitialized imapsql backends while preserving ManageableStorage support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Initialize and properly tear down storage/auth modules used by CLI tools.
This fixes
imap-acctpanics (nil UpdateManager) and preservesManageableStorageso account management continues to work.Changes
LifetimeModules inopenStorage/openUserDBStop()on Close()imap-acctseesManageableStorageTesting
maddy creds create …(works)maddy imap-acct create …(works)