don't use PyCrypto library because it's unmaintained + fix MacOS decryption code not removing 16 bytes padding + handle garbage data at end (windows and android) + edit text

[xBZZZZ]

read title

[naoei]

Thank you for the contribution, however it would be much better if you were to split this PR into four, each with the changes you've made in the title. I haven't gone and look into the changes yet but I'll wait until you split it into multiple PRs before reviewing.

[nekitdev]

I need some confirmation as to if the last 4 bytes are garbage here. We are using pycryptodome, which is actively maintained. I'm pretty sure the last 16 bytes are removed, though?

[xBZZZZ]

How do I split don't use PyCrypto library because it's unmaintained + fix MacOS decryption code not removing 16 bytes padding?

[naoei]

First off, please learn how to use Git - more specifically Git Branches. There are plenty of great tutorials online to help you with that.

Once you have learned that, create a branch for each of the changes and PR them as normally (making sure you're selecting the correct branch you want to merge in).

[xBZZZZ]

I'm pretty sure the last 16 bytes are removed, though?

I think that remove_pad function doesn't work when pad is 16 because 16 is not less than 16.

[xBZZZZ]

I don't know how to split don't use PyCrypto library because it's unmaintained + fix MacOS decryption code not removing 16 bytes padding because new MacOS decryption code is completely different than original (link goes to line in files changed tab).

This is not git's fault.

[naoei]

I don't know how to split don't use PyCrypto library because it's unmaintained + fix MacOS decryption code not removing 16 bytes padding because new MacOS decryption code is completely different than original

That's fine to keep as one PR then.

[xBZZZZ]

I splitted this pull request into #104, #105, #106, #107.

[nekitdev]

I'm pretty sure the last 16 bytes are removed, though?

I think that remove_pad function doesn't work when pad is 16 because 16 is not less than 16.

pad can't be 16 because padding is not added if the size is divisible by 16.

[xBZZZZ]

pad can't be 16 because padding is not added if the size is divisible by 16.

Padding is added if size is divisible by 16.

here is CCLocalLevels.dat from geometry dash for MacOS where padding = 16: https://gdccdated.glitch.me/s/CCLocalLevels_mac16pad.dat

[nekitdev]

Yeah, you are correct here. Still, we're not using cryptography as it contains much more than we actually need.