Trust libpq-fe.h's defines over probing in extconf.rb #696
+28
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The headers of libpq already give us nice defines for almost all features we want to support based when available so let's just trust libpq-fe.h to simplify our code. The only exception is PQresultMemorySize() which we need to check for manually since it was added in PostgreSQL 12, before libq-fe.h started adding defines for new features.
jeltz
force-pushed
the
use-libpq-defines
branch
from
59166ca to
0c3ea2b
Compare
Collaborator
|
The downside is, that there's no central point in the sources, where we can add the related PostgreSQL version like This makes cleaning up later a bit more difficult. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The headers of libpq already give us nice defines for almost all features we want to support based when available so let's just trust
libpq-fe.hto simplify our code.The only exception is
PQresultMemorySize()which we need to check for manually since it was added in PostgreSQL 12, beforelibq-fe.hstarted adding defines for new features.