feat!: rewrite CDL parser to recursive descent with v1.3 features#7
Merged
feat!: rewrite CDL parser to recursive descent with v1.3 features#7
Conversation
Full rewrite of both website and worker CDL parsers from regex-based to recursive descent. Supports parenthesized grouping, form labels, @name/$name definitions and references, flatForms() helper, and multi-line CDL input. BREAKING CHANGE: Internal parser architecture changed from regex to recursive descent. External API (parseCDL, validateCDL) unchanged.
|
🚀 Preview deployed to: https://ab35b16a.gemmology-dev.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workers/crystal-apisubmodule with matching parser rewriteflatForms()helper for backwards-compatible flat list accessBREAKING CHANGE: Internal parser architecture changed from regex to recursive descent. External API (
parseCDL,validateCDL) unchanged.Files changed
src/lib/cdl-parser.ts- full recursive descent rewrite (802 insertions)src/hooks/useCDLValidation.ts- multi-line CDL supportworkers/crystal-api- updated submodule ref (see gemmology-dev/crystal-api PR)Test plan
@name/$namedefinitions and references resolve in playgroundnpm run buildsucceeds without errors