Conversation
|
🚀 Deployed on https://preview-87--hedgehog-docs.netlify.app |
mrbojangles3
force-pushed
the
remove_control_proxy
branch
from
ddb71b6 to
b2c9337
Compare
mrbojangles3
force-pushed
the
remove_control_proxy
branch
from
b2c9337 to
d89383f
Compare
mrbojangles3
force-pushed
the
remove_control_proxy
branch
from
94f1596 to
a11f1f7
Compare
qmonnet
requested changes
Apr 2, 2025
Member
qmonnet
left a comment
qmonnet
left a comment
There was a problem hiding this comment.
It would be so much easier for reviewers if you had one commit that simply moves stuff around (+ possibly rewrap text, why not), and a separate one in which you edit/add/remove things. The current PR makes it difficult to understand what goes where, what's being removed or added.
qmonnet
requested changes
Apr 2, 2025
qmonnet
approved these changes
Apr 3, 2025
Member
qmonnet
left a comment
qmonnet
left a comment
There was a problem hiding this comment.
Looks OK to me, thanks! Please squash your fixes and clean up your commit description (making sure to address the DCO action report).
mrbojangles3
force-pushed
the
remove_control_proxy
branch
from
a41cc3d to
0110389
Compare
Also remove mentions of vlab outside of vlab section. Take Pau's suggestion to document password hash generation. Add links to external telemetry. Signed-off-by: Logan Blyth <logan@githedgehog.com> Apply suggestions from Quentin Co-authored-by: Quentin Monnet <qmo@qmon.net>
mrbojangles3
force-pushed
the
remove_control_proxy
branch
from
0110389 to
bb40d6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #80
Take @pau-hedgehog's suggestion to document password hash generation. Add links to external telemetry.