C/C++ overlay: discard single location elements#21063
Open
Conversation
IdrissRio
force-pushed
the
idrissrio/cpp/overlay/single-location
branch
from
8e63f2b to
8969f59
Compare
IdrissRio
force-pushed
the
idrissrio/cpp/overlay/single-location
branch
from
8969f59 to
cd09cfb
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the overlay analysis functionality in C++ to properly handle additional element types with single locations. The change ensures that more types of code elements are correctly discarded from the base variant when they appear in changed files during overlay analysis.
Changes:
- Extended
getSingleLocationFilePathpredicate to include 15 additional element types (diagnostics, usings, static_asserts, derivations, frienddecls, comments, exprs, stmts, initialisers, attributes, attribute_args, namequalifiers, enumconstants, type_mentions, lambda_capture, and concept_templates)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See internal PR ands linked issue