Add NativeBuildResolver in buildSrc as Kotlin replacement for NativiBuildInfo#1477
Open
prbprbprb wants to merge 1 commit intogoogle:masterfrom
Open
Add NativeBuildResolver in buildSrc as Kotlin replacement for NativiBuildInfo#1477prbprbprb wants to merge 1 commit intogoogle:masterfrom
prbprbprb wants to merge 1 commit intogoogle:masterfrom
Conversation
…uildInfo Extracts the native build platform/architecture configuration from the Groovy NativeBuildInfo enum in openjdk/build.gradle into well-tested Kotlin in buildSrc/. This is a no-op change -- nothing references these classes yet. The intent is to land and iterate on the API before wiring it into the build in a follow-up PR. Deliberate differences from the Groovy NativeBuildInfo: - findAll(os, arch) takes both os and arch, where the Groovy version takes only os. This is equivalent for all current variants (macOS crossCompile=true always returns both archs; Linux returns one) but allows for future expansion. - buildDir is an immutable Provider<Directory> passed at construction time, replacing the mutable static "String buildDir = FIXME" that was set later by the build script. This uses Gradle lazy configuration properly and eliminates shared mutable state. - crossCompile is an explicit boolean field on the enum rather than being implicit in the macOS libDir() override pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts the native build platform/architecture configuration from the Groovy NativeBuildInfo enum in openjdk/build.gradle into well-tested Kotlin in buildSrc/. This is a no-op change -- nothing references these classes yet. The intent is to land and iterate on the API before wiring it into the build in a follow-up PR.
Deliberate differences from the Groovy NativeBuildInfo:
findAll(os, arch) takes both os and arch, where the Groovy version takes only os. This is equivalent for all current variants (macOS crossCompile=true always returns both archs; Linux returns one) but allows for future expansion.
buildDir is an immutable Provider passed at construction time, replacing the mutable static "String buildDir = FIXME" that was set later by the build script. This uses Gradle lazy configuration properly and eliminates shared mutable state.
crossCompile is an explicit boolean field on the enum rather than being implicit in the macOS libDir() override pattern.
This is a no-op subset of #1388 with improved testing and docs which will help with #1475, #1034 etc