Skip to content

fix: show full Optional[T] type in help instead of just Optional #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thakoreh wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −7
Open

fix: show full Optional[T] type in help instead of just Optional #645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions fire/helptext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,13 +524,9 @@ def _GetArgType(arg, spec):
"""
if arg in spec.annotations:
arg_type = spec.annotations[arg]
try:
return arg_type.__qualname__
except AttributeError:
# Some typing objects, such as typing.Union do not have either a __name__
# or __qualname__ attribute.
# repr(typing.Union[int, str]) will return ': typing.Union[int, str]'
return repr(arg_type)
# Use repr() to get full type representation including generic args (e.g., Optional[str])
# This fixes the bug where __qualname__ returns just "Optional" instead of "Optional[str]"
return repr(arg_type)
return ''


Expand Down