chore: librarian generate pull request: 20260218T081656Z#15577
Conversation
Summary of ChangesHello @cloud-sdk-librarian-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, generated by the Librarian CLI, updates various Google Cloud client libraries by incorporating several new features, enhancements, and documentation improvements from recent proto changes. Key updates include expanded support for project-level configurations and key usage tracking in KMS, new post-quantum signature algorithms, and the introduction of resource deletion and tracking for KMS keys. Additionally, it adds new cluster types for Dataproc, extends Google Maps Places API with new link and type label fields, and enhances Storage Batch Operations with multi-bucket job indicators and new states. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This PR is an automated update from the Librarian tool, incorporating various new features, fixes, and documentation changes across multiple client libraries from new protobuf definitions. The changes include adding support for project-level key usage tracking in KMS Inventory, new post-quantum signature algorithms in KMS, and several other enhancements. The generated code and test updates appear to be correct. I have one suggestion regarding the new path helpers in the KMS Inventory client for improved consistency and clarity.
| def protected_resource_scope_path( | ||
| organization: str, | ||
| ) -> str: | ||
| """Returns a fully-qualified protected_resource_scope string.""" | ||
| return "organizations/{organization}/protectedResourceScope".format( | ||
| organization=organization, | ||
| ) | ||
|
|
||
| @staticmethod | ||
| def parse_protected_resource_scope_path(path: str) -> Dict[str, str]: | ||
| """Parses a protected_resource_scope path into its component segments.""" | ||
| m = re.match( | ||
| r"^organizations/(?P<organization>.+?)/protectedResourceScope$", path | ||
| ) | ||
| return m.groupdict() if m else {} |
There was a problem hiding this comment.
These new path helpers only handle organization-scoped paths, but search_protected_resources now also accepts project scopes. For consistency, please consider adding helpers for project-scoped paths.
Additionally, the name protected_resource_scope_path is confusing. The scope parameter of search_protected_resources expects a path like organizations/{org}, but this helper generates organizations/{org}/protectedResourceScope. Please clarify the purpose of this helper or align its output with the scope parameter format.
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.
BEGIN_COMMIT
BEGIN_NESTED_COMMIT
feat: Add support for project level key usage tracking
PiperOrigin-RevId: 871667322
Library-IDs: google-cloud-kms-inventory
Source-link: googleapis/googleapis@1133adb1
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add KeyProjectResolutionMode to AutokeyConfig to support project-level configurations
PiperOrigin-RevId: 870858133
Library-IDs: google-cloud-kms
Source-link: googleapis/googleapis@b026ba89
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add more post-quantum (PQ) signature algorithms to CryptoKeyVersion
PiperOrigin-RevId: 870858133
Library-IDs: google-cloud-kms
Source-link: googleapis/googleapis@b026ba89
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: Update documentation for AutokeyAdmin service and messages to support folder and project-level configurations
PiperOrigin-RevId: 870858133
Library-IDs: google-cloud-kms
Source-link: googleapis/googleapis@b026ba89
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: Clarify supported resources for the crypto_key_backend field in ImportJob
PiperOrigin-RevId: 870858133
Library-IDs: google-cloud-kms
Source-link: googleapis/googleapis@b026ba89
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add new value
DETECT_INTENT_RESPONSE_VIEW_DEFAULTto enumDetectIntentResponseViewPiperOrigin-RevId: 869958840
Library-IDs: google-cloud-dialogflow-cx
Source-link: googleapis/googleapis@7b25d8c4
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: Add comment for enum value
DETECT_INTENT_RESPONSE_VIEW_UNSPECIFIEDin enumDetectIntentResponseViewPiperOrigin-RevId: 869958840
Library-IDs: google-cloud-dialogflow-cx
Source-link: googleapis/googleapis@7b25d8c4
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
advisory_publish_timeis added to message.grafeas.v1.VulnerabilityNotePiperOrigin-RevId: 869922618
Library-IDs: grafeas
Source-link: googleapis/googleapis@67810511
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new field
registryis added to message.grafeas.v1.BaseImagePiperOrigin-RevId: 869922618
Library-IDs: grafeas
Source-link: googleapis/googleapis@67810511
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add
ClusterTypeto support creating Zero-Scale clustersPiperOrigin-RevId: 869501236
Library-IDs: google-cloud-dataproc
Source-link: googleapis/googleapis@d84d3c29
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add
googleMapsLinksfield for links to different actions on Google MapsPiperOrigin-RevId: 869356577
Library-IDs: google-maps-places
Source-link: googleapis/googleapis@6eead6ed
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
photosin message.google.maps.places.v1.ContextualContentis changedPiperOrigin-RevId: 869356577
Library-IDs: google-maps-places
Source-link: googleapis/googleapis@6eead6ed
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
fix: An existing field
topicis removed from message.google.maps.places.v1.ContentBlockPiperOrigin-RevId: 869356577
Library-IDs: google-maps-places
Source-link: googleapis/googleapis@6eead6ed
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
reviewsin message.google.maps.places.v1.ContextualContentis changedPiperOrigin-RevId: 869356577
Library-IDs: google-maps-places
Source-link: googleapis/googleapis@6eead6ed
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add
googleMapsTypeLabelfield to show type information on Google MapsPiperOrigin-RevId: 869356577
Library-IDs: google-maps-places
Source-link: googleapis/googleapis@6eead6ed
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
fix: An existing field
referencesis removed from message.google.maps.places.v1.ContentBlockPiperOrigin-RevId: 869356577
Library-IDs: google-maps-places
Source-link: googleapis/googleapis@6eead6ed
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add
is_multi_bucket_joboutput field added to StorageBatchOperations JobPiperOrigin-RevId: 869283881
Library-IDs: google-cloud-storagebatchoperations
Source-link: googleapis/googleapis@fb371add
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add QUEUED state to Storage Batch Operations API
PiperOrigin-RevId: 869283881
Library-IDs: google-cloud-storagebatchoperations
Source-link: googleapis/googleapis@fb371add
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add bucket operations
PiperOrigin-RevId: 869283881
Library-IDs: google-cloud-storagebatchoperations
Source-link: googleapis/googleapis@fb371add
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add AppHub related condition types to Deployment protos
PiperOrigin-RevId: 869245151
Library-IDs: google-cloud-saasplatform-saasservicemgmt
Source-link: googleapis/googleapis@772f1961
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Added DeleteCryptoKey and DeleteCryptoKeyVersion RPCs to permanently remove resources
PiperOrigin-RevId: 868670725
Library-IDs: google-cloud-kms
Source-link: googleapis/googleapis@f248ed08
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Added ListRetiredResources and GetRetiredResource RPCs to manage and view these records
PiperOrigin-RevId: 868670725
Library-IDs: google-cloud-kms
Source-link: googleapis/googleapis@f248ed08
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Introduced the RetiredResource resource to track records of deleted keys and prevent the reuse of their resource names
PiperOrigin-RevId: 868670725
Library-IDs: google-cloud-kms
Source-link: googleapis/googleapis@f248ed08
END_NESTED_COMMIT
END_COMMIT
This pull request is generated with proto changes between
googleapis/googleapis@9eea40c7
(exclusive) and
googleapis/googleapis@1133adb1
(inclusive).
Librarian Version: v0.0.0-20260216162532-e323d455c92b
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:f5426423676c75008c2135037e7b98f78cbb99f78b3c46fe043b6897be92d836