Skip to content

chore(ci): enable workflows and scripts on preview (#15581)#15583

Closed
noahdietz wants to merge 1 commit intogoogleapis:mainfrom
noahdietz:preview-ci
Closed

chore(ci): enable workflows and scripts on preview (#15581)#15583
noahdietz wants to merge 1 commit intogoogleapis:mainfrom
noahdietz:preview-ci

Conversation

@noahdietz
Copy link
Contributor

Cherry pick commit from main for #15581

@noahdietz noahdietz closed this Feb 19, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @noahdietz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the continuous integration (CI) system by introducing flexibility in how target branches are referenced within core CI scripts. The primary goal is to enable CI workflows to run against various branches, including preview branches, by making the target branch configurable. This change improves the adaptability and reusability of the CI infrastructure.

Highlights

  • CI Script Generalization: The ci/run_conditional_tests.sh script has been updated to dynamically determine the target branch for Git operations, rather than hardcoding 'main'.
  • Configurable Target Branch: A new TARGET_BRANCH environment variable is now used, defaulting to 'main', allowing CI workflows to be executed against different branches, such as 'preview'.
  • Shell Conditional Syntax Update: The conditional statements in the script were updated from [ ... ] to [[ ... ]] for improved shell scripting practices.
Changelog
  • ci/run_conditional_tests.sh
    • Introduced a TARGET_BRANCH variable, defaulting to 'main', to allow dynamic specification of the Git target branch.
    • Updated Git diff and fetch commands to utilize the new TARGET_BRANCH variable.
    • Migrated shell conditional syntax from [ ... ] to [[ ... ]] for improved robustness.
Ignored Files
  • Ignored by pattern: .github/workflows/** (3)
    • .github/workflows/docs.yml
    • .github/workflows/lint.yml
    • .github/workflows/unittest.yml
Activity
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the ci/run_conditional_tests.sh script to use a TARGET_BRANCH variable instead of hardcoding main. This change improves the flexibility of the CI workflows, allowing them to be run against different target branches, which is particularly useful for preview environments or feature branches. The use of [[ ... ]] for conditional expressions is also a good practice for bash scripting.

@noahdietz noahdietz deleted the preview-ci branch February 19, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments