chore(ci): enable workflows and scripts on preview (#15581)#15583
chore(ci): enable workflows and scripts on preview (#15581)#15583noahdietz wants to merge 1 commit intogoogleapis:mainfrom
Conversation
Summary of ChangesHello @noahdietz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the continuous integration (CI) system by introducing flexibility in how target branches are referenced within core CI scripts. The primary goal is to enable CI workflows to run against various branches, including preview branches, by making the target branch configurable. This change improves the adaptability and reusability of the CI infrastructure. Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request updates the ci/run_conditional_tests.sh script to use a TARGET_BRANCH variable instead of hardcoding main. This change improves the flexibility of the CI workflows, allowing them to be run against different target branches, which is particularly useful for preview environments or feature branches. The use of [[ ... ]] for conditional expressions is also a good practice for bash scripting.
Cherry pick commit from
mainfor #15581