Conversation
kailun-qin
left a comment
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @dimakuv)
-- commits line 6 at r1:
I think we can simply remove this as it's not in the CI-examples any more
Code quote:
(to quickly test functionality)
-- commits line 7 at r1:
ditto
Code quote:
(to test performance)
candle/README.md line 4 at r1 (raw file):
Candle is a minimalist ML framework for Rust with a focus on performance (including GPU support) and ease of use: https://github.com/huggingface/candle
Can we use inline links? Besides, missing period at the end of this sentence.
Code quote:
https://github.com/huggingface/candle
kailun-qin
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 4 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @dimakuv)
candle/candle_matmul.manifest.template line 3 at r1 (raw file):
# Copyright (C) 2024 Gramine contributors # SPDX-License-Identifier: BSD-3-Clause
we don't have loader.entrypoint meaning that we have to hold this PR until after the next Gramine release is done
c11d244 to
5a3494d
Compare
dimakuv
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 6 files reviewed, 4 unresolved discussions, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @kailun-qin)
Previously, kailun-qin (Kailun Qin) wrote…
I think we can simply remove this as it's not in the CI-examples any more
Done.
Previously, kailun-qin (Kailun Qin) wrote…
ditto
Done.
candle/README.md line 4 at r1 (raw file):
Previously, kailun-qin (Kailun Qin) wrote…
Can we use inline links? Besides, missing period at the end of this sentence.
Done.
candle/candle_matmul.manifest.template line 3 at r1 (raw file):
Previously, kailun-qin (Kailun Qin) wrote…
we don't have
loader.entrypointmeaning that we have to hold this PR until after the next Gramine release is done
Done.
No, I think we should add the loader.entrypoint now, and then apply #99 to all examples, including Candle.
kailun-qin
left a comment
There was a problem hiding this comment.
Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @dimakuv)
candle/README.md line 4 at r2 (raw file):
[Candle](https://github.com/huggingface/candle) is a minimalist ML framework for Rust with a focus on performance (including GPU support) and ease of use.
trailing white space?
Code quote:
·Candle is a minimalist ML framework for Rust with a focus on performance and ease of use. This commit adds the Quantized LLaMA example. Signed-off-by: Dmitrii Kuvaiskii <dmitrii.kuvaiskii@intel.com>
5a3494d to
147ba0f
Compare
dimakuv
left a comment
There was a problem hiding this comment.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion, not enough approvals from maintainers (2 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @kailun-qin)
candle/README.md line 4 at r2 (raw file):
Previously, kailun-qin (Kailun Qin) wrote…
trailing white space?
Done.
kailun-qin
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: Intel)
Candle is a minimalist ML framework for Rust with a focus on performance and ease of use. This commit adds two examples with Candle: simple matrix multiplication (to quickly test functionality) and Quantized LLaMA (to test performance).
Originally was submitted in core Gramine repo, but it was agreed to move it in this separate repo: gramineproject/gramine#1938
This change is