Skip to content
/ hyper-util Public

Decompose hyper::Client into utils (part 1)#31

Open
tomkarw wants to merge 1 commit intohyperium:masterfrom
tomkarw:decompose-client-into-utils
Open

Decompose hyper::Client into utils (part 1)#31
tomkarw wants to merge 1 commit intohyperium:masterfrom
tomkarw:decompose-client-into-utils

Conversation

@tomkarw
Copy link
Contributor

@tomkarw tomkarw commented Aug 7, 2023 •
edited
Loading

@tomkarw tomkarw force-pushed the decompose-client-into-utils branch from 7d512f9 to 57299e2 Compare August 7, 2023 18:44
@tomkarw tomkarw changed the title WIP: feat: SetHost, Http1RequestTarget and DelayedResposne middlewares WIP: Decompose Client into utils Aug 9, 2023
@tomkarw tomkarw changed the title WIP: Decompose Client into utils WIP: Decompose hyper::Client into utils Aug 9, 2023
@tomkarw tomkarw force-pushed the decompose-client-into-utils branch 3 times, most recently from 5325527 to 3ae4950 Compare August 24, 2023 18:33
@seanmonstar
Copy link
Member

seanmonstar commented Aug 30, 2023

This looks pretty good to me! Is it still WIP?

@tomkarw tomkarw changed the title WIP: Decompose hyper::Client into utils Decompose hyper::Client into utils (part 1) Aug 31, 2023
@ikrivosheev
Copy link

ikrivosheev commented Jan 16, 2024

@tomkarw any updates? Or can i open new PR?

@tomkarw
Copy link
Contributor Author

tomkarw commented Jan 18, 2024

As far as I'm concerned this was ready, I was waiting for a review from @seanmonstar, but assumed he's busy with hyper v1 release.

I'll brush it up and hope to merge it in. I don't think making a new PR makes sense.

@tomkarw tomkarw force-pushed the decompose-client-into-utils branch from 3ae4950 to 672b8b9 Compare January 18, 2024 21:53
@ikrivosheev
Copy link

ikrivosheev commented Jan 19, 2024

As far as I'm concerned this was ready, I was waiting for a review from @seanmonstar, but assumed he's busy with hyper v1 release.

I'll brush it up and hope to merge it in. I don't think making a new PR makes sense.

Thank you) this branch had conflicts and if you didn't respond I would open new PR. Sorry, if I confused you.

@tomkarw tomkarw force-pushed the decompose-client-into-utils branch from 672b8b9 to 43891d0 Compare January 26, 2024 23:40
@tomkarw
Copy link
Contributor Author

tomkarw commented Jan 26, 2024

This is blocked on decision regarding Http1RequestTarget and is_proxied. I'd love to get someone's opinion on that: hyperium/hyper#3080 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Decompose Client into utils

3 participants

@tomkarw @seanmonstar @ikrivosheev