Conversation
Contributor
|
Why hadolint ? |
Collaborator
Author
|
This - in my opinion - is the linter with the largest community. I am open to other suggestions. |
Contributor
|
Is the largest community the most important factor to take into account in here ? any other angels ? I am not against, I just want to understand why hadolint and not something else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I introduced the hadolint and adapted to its requirements. Before the changes, it reported the following errors:
I do not think that we want to make all changes immediately. However, we can review rules, select which apply to facilitate future maintenance (as any tests), especially after transferring the task to fresh person.