Make SDK compatible with Angular 18 #116
Open
hypnotoad08 wants to merge 6 commits intoimagekit-developer:masterfrom
Open
Make SDK compatible with Angular 18 #116hypnotoad08 wants to merge 6 commits intoimagekit-developer:masterfrom
hypnotoad08 wants to merge 6 commits intoimagekit-developer:masterfrom
Conversation
Author
|
@ahnv Any progress/ comments on this? Angular is now on version 19 as of last November. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am attempting to use this SDK in an Angular 18 project and it is incompatible. I see the library is targeting Angular 12 which was released 3 years ago and has been out of active support for 2 years and 9 months. - https://endoflife.date/angular
I have bumped the dependencies up to Angular 16 and made a change to the imagekitio-angular.module.ts to include CUSTOM_ELEMENTS_SCHEMA as elements like
<ik-upload>are invalid with out it.I have built the library, packaged it, and installed it locally in my app. I am now able to use
<ik-upload>in my standalone Angular 18 components.In addition to installing the custom built version of the SDK, Angular 18 requires you to use the following syntax when defining the ImagekitioAngularModule.forRoot in my AppConfig providers.