Updated snappy cffi to use CFFI 1.0 out-of-line API mode#63
Merged
martindurant merged 1 commit intointake:masterfrom Jan 28, 2018
Merged
Updated snappy cffi to use CFFI 1.0 out-of-line API mode#63martindurant merged 1 commit intointake:masterfrom
martindurant merged 1 commit intointake:masterfrom
Conversation
|
👍 |
|
@andrix Any chance to get this merged and issue a new version? |
Member
|
I can merge. By release, do you mean a git-tag, pypi, conda-forge or all three? |
|
@martindurant I mean git tag and pypi at least, so that we can pip install the new version |
Member
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been getting race conditions with the older cffi method because it creates the
.sofile in run time, so several forking processes overwrite eachothers'.sofiles.I updated the library to use the cffi 1.0 API out-of-line mode which builds the .so file on package install instead of dynamically when it's loaded.