chore: Remove package name to satisfy automated security checks#2
chore: Remove package name to satisfy automated security checks#2Jakub Kadlubiec (jakubka) wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the "name" and "version" fields from package.json to satisfy automated security checks in a public code exercise repository. The repository uses ES modules and contains JavaScript exercises with no external dependencies or npm publishing workflows.
Changes:
- Removed "name" field ("activities-stats") from package.json
- Removed "version" field ("1.0.0") from package.json
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,6 +1,4 @@ | |||
| { | |||
There was a problem hiding this comment.
Removing the "name" and "version" fields from package.json may cause issues with npm tooling and package management. While technically valid for a non-published package, many npm commands and tools expect these fields to be present. Consider whether this is the correct approach to satisfy security checks. If the security concern is about exposing the package name "activities-stats", consider alternatives such as renaming the package or configuring the security scanning tool to exclude this repository. Could you clarify which specific security check requires this removal?
| { | |
| { | |
| "name": "activities-stats", | |
| "version": "1.0.0", |
|
Jakub Kadlubiec (@jakubka) Could you please edit the codeowners file so the PR does not ping the entire engineering? 🙏 |
Petr Martišek (@petrm-integromat) yeah, I need to tweak it. That wasn't the intention. I want everyone to be able to change this repo, but without getting notified. |
No description provided.