add va_dec_avs & va_dec_avs2 by gitgjogh · Pull Request #738 · intel/libva

gitgjogh · 2023-07-25T11:29:29Z

add VAProfileAVSJizhun and VAProfileAVSGuangdian
add VAProfileAVS2Main and VAProfileAVS2Main10

Signed-off-by: jianfeng.zheng jianfeng.zheng@mthreads.com

gitgjogh · 2023-07-25T12:01:56Z

Hi there,

I'm grad to announce that we, Moore Threads, have finished Chinese AVS&AVS2 hwaccel decoding under FFMpeg-VAAPI framework. As mentioned before in #664, all our public products, MTT S10/MTT S50/MTT S80/MTT S2000/... support AVS&AVS+ decoding at max 2K and support AVS2 Main&Main10 decoding at max 8K.

This PR is the patches for libva.

For FFmpeg implementaion, please refer to

gitgjogh/FFmpeg#1

I will also submit the corresponding patches to FFMpeg lately.

Thanks,
Jianfeng

dvrogozh

Is there open source driver available which supports AVS and AVS2?

va/va_dec_avs.h

gitgjogh · 2023-07-27T03:25:51Z

Sorry, our driver is currently not open source. AVS/AVS2 spec and reference decoder can be retrieved from http://www.avs.org.cn/index/list?catid=7. For AVS2, there is an open source decoder, [davs2]( https://github.com/pkuvcl/davs2), implemented by Chinese [Peking University](https://www.pku.edu.cn/). `davs2` has been integrated into FFMpeg as a 3rd-party decoder. Dmitry Rogozhkin ***@***.***> 于2023年7月26日周三 00:44写道：

…

***@***.**** commented on this pull request. Is there open source driver available which supports AVS and AVS2? — Reply to this email directly, view it on GitHub <#738 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJERSGUQRIDNUIVMNRD2ZTXR7ZXHANCNFSM6AAAAAA2W5SLRE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

XinfengZhang · 2023-08-17T14:50:48Z

I am ok to accept the AVS and AVS2 decode interfaces, but how to guarantee the usage? and guarantee the health, looks there are no open source project are using it, and no test application , no test coverage?
will there some open source project in future or some sample code added in https://github.com/intel/libva-utils

gitgjogh · 2023-09-28T05:14:54Z

I am ok to accept the AVS and AVS2 decode interfaces, but how to guarantee the usage? and guarantee the health, looks there are no open source project are using it, and no test application , no test coverage? will there some open source project in future or some sample code added in https://github.com/intel/libva-utils

@XinfengZhang Please see intel/libva-utils#346, As mentioned, we also implemented ffmpeg-vaapi decoding for AVS and AVS2. Please see gitgjogh/FFmpeg#1. The PR would be submmitted to FFMpeg devel after this PR being accepted.

gitgjogh · 2023-11-08T13:20:05Z

Hi @dvrogozh @XinfengZhang, is this PR still in reviewing?

see intel/libva#738 [Moore Threads](https://www.mthreads.com) (short for Mthreads) is a Chinese GPU manufacturer. All our products, like MTTS70/MTTS80/.. , support AVS/AVS+ HW decoding at max 2k resolution. Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>

see intel/libva#738 [Moore Threads](https://www.mthreads.com) (short for Mthreads) is a Chinese GPU manufacturer. All our products, like MTTS70/MTTS80/.. , support AVS2 8bit/10bit HW decoding at max 8k resolution. Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>

see intel/libva#738 [Moore Threads](https://www.mthreads.com) (short for Mthreads) is a Chinese GPU manufacturer. All our products, like MTTS70/MTTS80/.. , support AVS/AVS+ HW decoding at max 2k resolution. Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>

see intel/libva#738 Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>

Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>

xhaihao · 2024-01-31T04:46:29Z

va/va_dec_avs.h

+    uint16_t fixed_pic_qp_flag                      :  1;
+    uint16_t picture_qp                             :  6;
+    uint16_t loop_filter_disable_flag               :  1;
+    uint16_t skip_mode_flag_flag                    :  1;


Is skip_mode_flag_flag a typo ? I guess it should be skip_mode_flag.

xhaihao · 2024-01-31T04:55:17Z

va/va_trace.c

+    DPY2TRACECTX(dpy, context, VA_INVALID_ID);
+
+    switch (type) {
+


Could you add code to dump each field in avs2 buffer ?

xhaihao · 2024-01-31T04:55:29Z

va/va_trace.c

+    DPY2TRACECTX(dpy, context, VA_INVALID_ID);
+
+    switch (type) {
+


Could you add code to dump each field in avs buffer ?

MollyHu1 · 2025-03-25T00:21:02Z

@XinfengZhang and HaiHao.
I think it's good to enable AVS on libva since it is Chinese standard. Vendor can support or it on UMD by HW or SW.

XinfengZhang · 2025-03-25T02:33:43Z

as my previous comments:
if there are open source stack to use it? for example: an open source driver ?

gitgjogh mentioned this pull request Jul 25, 2023

va not support private profile such as AVS,AVS2 and private interface #522

Open

dvrogozh reviewed Jul 25, 2023

View reviewed changes

va/va_dec_avs.h Outdated Show resolved Hide resolved

va/va_dec_avs.h Outdated Show resolved Hide resolved

gitgjogh force-pushed the master branch from 1e0c9b4 to 0a67d7b Compare July 26, 2023 02:28

gitgjogh force-pushed the master branch from 0fef9b7 to 4a49f9d Compare August 7, 2023 08:04

gitgjogh force-pushed the master branch from 4a49f9d to eab0b74 Compare September 27, 2023 10:35

gitgjogh mentioned this pull request Sep 28, 2023

test: add VAProfileAVSxxx and VAProfileAVS2xxx intel/libva-utils#346

Open

gitgjogh force-pushed the master branch from eab0b74 to a592b25 Compare October 16, 2023 10:50

gitgjogh force-pushed the master branch 2 times, most recently from a4d198a to 620f456 Compare October 31, 2023 04:42

gitgjogh pushed a commit to gitgjogh/FFmpeg that referenced this pull request Jan 21, 2024

cavs: support vaapi hwaccel decoding

4ab54ad

see intel/libva#738 Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>

jianfeng.zheng added 2 commits January 22, 2024 20:17

add VAProfileAVSJizhun and VAProfileAVSGuangdian

ac3fe55

Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>

add VAProfileAVS2Main and VAProfileAVS2Main10

564420c

Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>

gitgjogh force-pushed the master branch from 60822cd to 564420c Compare January 22, 2024 12:17

xhaihao reviewed Jan 31, 2024

View reviewed changes

va/va_trace.c

DPY2TRACECTX(dpy, context, VA_INVALID_ID);

switch (type) {

Copy link

Contributor

xhaihao Jan 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add code to dump each field in avs2 buffer ?

xhaihao reviewed Jan 31, 2024

View reviewed changes

va/va_trace.c

DPY2TRACECTX(dpy, context, VA_INVALID_ID);

switch (type) {

Copy link

Contributor

xhaihao Jan 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add code to dump each field in avs buffer ?

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add va_dec_avs & va_dec_avs2#738

add va_dec_avs & va_dec_avs2#738
gitgjogh wants to merge 2 commits intointel:masterfrom
gitgjogh:master

gitgjogh commented Jul 25, 2023 •

edited

Loading

Uh oh!

gitgjogh commented Jul 25, 2023 •

edited

Loading

Uh oh!

dvrogozh left a comment

Uh oh!

Uh oh!

Uh oh!

gitgjogh commented Jul 27, 2023 via email

Uh oh!

XinfengZhang commented Aug 17, 2023

Uh oh!

gitgjogh commented Sep 28, 2023 •

edited

Loading

Uh oh!

gitgjogh commented Nov 8, 2023 •

edited

Loading

Uh oh!

xhaihao Jan 31, 2024

Uh oh!

xhaihao Jan 31, 2024

Uh oh!

xhaihao Jan 31, 2024

Uh oh!

MollyHu1 commented Mar 25, 2025

Uh oh!

XinfengZhang commented Mar 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

gitgjogh commented Jul 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gitgjogh commented Jul 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dvrogozh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gitgjogh commented Jul 27, 2023 via email

Uh oh!

XinfengZhang commented Aug 17, 2023

Uh oh!

gitgjogh commented Sep 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gitgjogh commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xhaihao Jan 31, 2024

Choose a reason for hiding this comment

Uh oh!

xhaihao Jan 31, 2024

Choose a reason for hiding this comment

Uh oh!

xhaihao Jan 31, 2024

Choose a reason for hiding this comment

Uh oh!

MollyHu1 commented Mar 25, 2025

Uh oh!

XinfengZhang commented Mar 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gitgjogh commented Jul 25, 2023 •

edited

Loading

gitgjogh commented Jul 25, 2023 •

edited

Loading

gitgjogh commented Sep 28, 2023 •

edited

Loading

gitgjogh commented Nov 8, 2023 •

edited

Loading