Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been thinking about this for a while, and issues like #35 have hammered home that this library is hiding too much of the underlying transport from users. I think we would have a lot more room to operate/fix problems without needing new versions of this library if it became more pluggable. To that end, I'm proposing a breaking set of changes that I think would reduce the size and maintenance burden of this library while still making it easy for others to build on top of it.
The primary changes are
Progress<T>andCancellationTokenparameters for the membersI think this will reduce a lot of conceptual friction, and make contributing new fixes to this library even easier.