Skip to content

Барышников Влад 6513 Лаб. 1#11

Open
dedrowe wants to merge 6 commits intoitsecd:mainfrom
dedrowe:feature/lab1
Open

Барышников Влад 6513 Лаб. 1#11
dedrowe wants to merge 6 commits intoitsecd:mainfrom
dedrowe:feature/lab1

Conversation

@dedrowe
Copy link

@dedrowe dedrowe commented Feb 22, 2026

ФИО: Барышников Влад
Номер группы: 6513
Номер лабораторной: 1
Номер варианта: 36
Краткое описание предметной области: Сотрудник компании
Краткое описание добавленных фич: Добавлен сервис генерации с кэшированием при помощи Redis, структурным логированием и оркестрацией Aspire

@github-actions github-actions bot added In progress Код в процессе проверки Lab 1 Лабораторная №1. Кэширование labels Feb 22, 2026
@github-actions github-actions bot requested a review from alxmcs February 22, 2026 13:31
@dedrowe dedrowe requested a review from alxmcs February 24, 2026 14:09
@dedrowe dedrowe requested a review from alxmcs February 24, 2026 16:05
Copy link
Collaborator

@alxmcs alxmcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Пара мелочей

.RuleFor(e => e.DismissalDate, (f, e) => !e.DismissalFlag ? null :
f.Date.BetweenDateOnly(e.EmploymentDate, DateOnly.FromDateTime(DateTime.UtcNow)));

logger.LogInformation("Generated employee with id {}", id);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Чудесное имя параметра в шаблоне, как же удобно будет его искать в струтурных логах

Comment on lines 9 to 10
/// </summary>
[ApiController]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Параметров праймари конструктора в саммари не хватает

@dedrowe dedrowe requested a review from alxmcs February 26, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

In progress Код в процессе проверки Lab 1 Лабораторная №1. Кэширование

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants