Горшенин Дмитрий Лаб. 2 Группа 6511 by dmgorshenin · Pull Request #7 · itsecd/cloud-development

dmgorshenin · 2026-02-18T12:36:32Z

ФИО: Горшенин Дмитрий
Номер группы: 6511
Номер лабораторной: 2
Номер варианта: 4
Краткое описание предметной области: Генератор кредитной заявки
Краткое описание добавленных фич: Реализация Gateway, настройка его работы

…аб. роботы В решение добавлены проекты CreditApplication.AppHost (Aspire-хост), CreditApplication.Generator (API генерации кредитных заявок с кэшированием в Redis) и CreditApplication.ServiceDefaults (общие настройки сервисов: логирование, OpenTelemetry, resilience, health checks). Реализована модель заявки, генератор на Bogus, сервис с кэшированием, API-эндпоинт /credit-application.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

… into Lab2

Copilot

Pull request overview

PR implements Lab #2 for the “Credit Application Generator” microservice system by adding an API Gateway layer and running multiple generator replicas under .NET Aspire orchestration.

Changes:

Added API Gateway service (Ocelot) with a custom weighted-random load balancer.
Added Aspire AppHost orchestration to run Redis + 3 generator replicas + gateway + client.
Introduced a shared ServiceDefaults project to centralize Serilog/OpenTelemetry/health checks/CORS wiring.

Reviewed changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
README.md	Replaced course template README with project/lab-specific documentation and architecture notes.
CreditApplication.ServiceDefaults/Extensions.cs	Added shared host defaults (logging, telemetry, health, CORS, service discovery).
CreditApplication.ServiceDefaults/CreditApplication.ServiceDefaults.csproj	New shared project packaging required defaults dependencies.
CreditApplication.Generator/*	New generator service (Bogus-based), Redis cache-aside service, and minimal API endpoint.
CreditApplication.Gateway/*	New gateway service, Ocelot routes config, and custom `WeightedRandomLoadBalancer`.
CreditApplication.AppHost/*	New Aspire AppHost wiring 3 generator replicas + gateway + redis (+ commander in Dev) + client.
CloudDevelopment.sln	Added new projects to the solution + extra build configurations.
Client.Wasm/wwwroot/appsettings.json	Pointed client configuration to the gateway endpoint.
Client.Wasm/Properties/launchSettings.json	Adjusted local run ports and disabled auto-launch browser.
Client.Wasm/Components/StudentCard.razor	Updated student/lab info displayed in UI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

CreditApplication.Generator/Program.cs

Copilot · 2026-02-18T12:41:30Z

CreditApplication.Gateway/Program.cs

+builder.Services.AddCors(options =>
+{
+    options.AddDefaultPolicy(policy =>
+    {
+        if (builder.Environment.IsDevelopment())
+        {
+            policy.AllowAnyOrigin()
+                  .AllowAnyMethod()
+                  .AllowAnyHeader();
+        }
+        else
+        {
+            var allowedOrigins = builder.Configuration
+                .GetSection("Cors:AllowedOrigins")
+                .Get<string[]>() ?? [];
+
+            policy.WithOrigins(allowedOrigins)
+                  .WithMethods("GET")
+                  .WithHeaders("Content-Type", "Authorization");
+        }
+    });
+});
+


AddGatewayDefaults() already registers a default CORS policy via AddDefaultCors(), but the gateway also calls builder.Services.AddCors() again and redefines the default policy. This double-registration makes the effective policy order-dependent and harder to maintain; consider configuring CORS in a single place (either keep it in ServiceDefaults and remove this block, or remove CORS from AddGatewayDefaults).

Suggested change

builder.Services.AddCors(options =>

{

options.AddDefaultPolicy(policy =>

{

if (builder.Environment.IsDevelopment())

{

policy.AllowAnyOrigin()

.AllowAnyMethod()

.AllowAnyHeader();

}

else

{

var allowedOrigins = builder.Configuration

.GetSection("Cors:AllowedOrigins")

.Get<string[]>() ?? [];

policy.WithOrigins(allowedOrigins)

.WithMethods("GET")

.WithHeaders("Content-Type", "Authorization");

}

});

});

Copilot · 2026-02-18T12:41:31Z

CreditApplication.Gateway/Program.cs

+builder.Configuration.AddJsonFile("ocelot.json", optional: false, reloadOnChange: true);
+
+var generatorNames = builder.Configuration.GetSection("GeneratorServices").Get<string[]>() ?? [];
+var addressOverrides = new List<KeyValuePair<string, string?>>();
+for (var i = 0; i < generatorNames.Length; i++)
+{
+    var url = builder.Configuration[$"services:{generatorNames[i]}:http:0"];
+    if (!string.IsNullOrEmpty(url) && Uri.TryCreate(url, UriKind.Absolute, out var uri))
+    {
+        addressOverrides.Add(new($"Routes:0:DownstreamHostAndPorts:{i}:Host", uri.Host));
+        addressOverrides.Add(new($"Routes:0:DownstreamHostAndPorts:{i}:Port", uri.Port.ToString()));
+    }
+}
+if (addressOverrides.Count > 0)
+    builder.Configuration.AddInMemoryCollection(addressOverrides);
+
+var weights = builder.Configuration
+    .GetSection("ReplicaWeights")
+    .Get<Dictionary<string, double>>() ?? new Dictionary<string, double>();
+
+builder.Services
+    .AddOcelot(builder.Configuration)
+    .AddCustomLoadBalancer((route, serviceDiscovery) =>
+        new WeightedRandomLoadBalancer(serviceDiscovery, weights));


The weights dictionary is keyed by the downstream host:port strings from config, but this file also overrides DownstreamHostAndPorts at runtime from Aspire service-discovery environment variables. After an override, the actual downstream host/port may no longer match the ReplicaWeights keys, causing the load balancer to fall back to the default weight (1.0) and ignore the intended 0.5/0.3/0.2 distribution. Consider keying weights by service name (e.g., generator-1/2/3) or rebuilding/rewriting the weight keys after applying the address overrides.

Copilot · 2026-02-18T12:41:31Z

CreditApplication.ServiceDefaults/Extensions.cs

+                        .GetSection("CorsAllowedOrigins")
+                        .Get<string[]>() ?? [];
+


AddDefaultCors() reads allowed origins from configuration section CorsAllowedOrigins, but the gateway (and typical appsettings structure) uses Cors:AllowedOrigins. Since nothing else in this PR defines CorsAllowedOrigins, production CORS settings configured under Cors:AllowedOrigins would be ignored by services using AddServiceDefaults(). Consider standardizing on one configuration path (e.g., Cors:AllowedOrigins) and updating ServiceDefaults accordingly.

Suggested change

.GetSection("CorsAllowedOrigins")

.Get<string[]>() ?? [];

.GetSection("Cors:AllowedOrigins")

.Get<string[]>();

if (allowedOrigins is null || allowedOrigins.Length == 0)

{

allowedOrigins = builder.Configuration

.GetSection("CorsAllowedOrigins")

.Get<string[]>() ?? [];

}

Copilot · 2026-02-18T12:41:31Z

CreditApplication.Generator/Services/CreditApplicationGenerator.cs

+    private static void SetStatusDependentFields(Faker faker, CreditApplicationModel app)
+    {
+        var isTerminal = _terminalStatuses.Contains(app.Status);
+
+        if (isTerminal)
+        {
+            app.DecisionDate = faker.Date.BetweenDateOnly(app.ApplicationDate, DateOnly.FromDateTime(DateTime.Today));
+
+            if (app.Status == "Одобрена")
+            {
+                var maxApproved = app.RequestedAmount;
+                var minApproved = maxApproved * 0.5m;
+                app.ApprovedAmount = Math.Round(faker.Random.Decimal(minApproved, maxApproved), 2);
+            }


The generator is described as deterministic via UseSeed(id), but DecisionDate is generated using DateTime.Today as an upper bound. This makes the same id potentially produce different results on different days (range length changes), which breaks determinism guarantees. Consider deriving DecisionDate deterministically from ApplicationDate (e.g., add a seeded random offset capped by a fixed max) rather than using the current date.

Copilot · 2026-02-18T12:41:32Z

Client.Wasm/Components/StudentCard.razor

+            <UnorderedListItem>Номер <Strong>№1 «Кэширование»</Strong></UnorderedListItem>
+            <UnorderedListItem>Вариант <Strong>№4 «Кредитная заявка»</Strong></UnorderedListItem>
+            <UnorderedListItem>Выполнена <Strong>Горшениным Дмитрием 6511</Strong> </UnorderedListItem>
+            <UnorderedListItem><Link To="https://github.com/dmgorshenin/cloud-development?tab=readme-ov-file">Ссылка на форк</Link></UnorderedListItem>


This card states that lab work №1 («Кэширование») was completed, but this PR is for lab №2 (API Gateway + load balancing). If the UI is intended to reflect the current lab/PR, update the lab number/title accordingly so the client page matches the submission.

Copilot · 2026-02-18T12:41:32Z

CreditApplication.AppHost/CreditApplication.AppHost.csproj

+<Sdk Name="Aspire.AppHost.Sdk" Version="9.0.0" />
+
+<PropertyGroup>
+    <OutputType>Exe</OutputType>
+    <TargetFramework>net8.0</TargetFramework>
+    <ImplicitUsings>enable</ImplicitUsings>
+    <Nullable>enable</Nullable>
+    <IsAspireHost>true</IsAspireHost>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <PackageReference Include="Aspire.Hosting" Version="9.5.2" />
+    <PackageReference Include="Aspire.Hosting.AppHost" Version="9.5.2" />
+    <PackageReference Include="Aspire.Hosting.Redis" Version="9.5.2" />


Aspire.AppHost.Sdk is pinned to 9.0.0 while the Aspire package references are 9.5.2. Mixing SDK and package versions can lead to subtle build/target mismatches; consider aligning the SDK version with the referenced Aspire package version (or vice versa) to keep the toolchain consistent.

danlla · 2026-02-26T10:36:10Z

Client.Wasm/Components/StudentCard.razor

-            <UnorderedListItem>Вариант <Strong>№Х "Название варианта"</Strong></UnorderedListItem>
-            <UnorderedListItem>Выполнена <Strong>Фамилией Именем 65ХХ</Strong> </UnorderedListItem>
-            <UnorderedListItem><Link To="https://puginarug.com/">Ссылка на форк</Link></UnorderedListItem>
+            <UnorderedListItem>Номер <Strong>№1 «Кэширование»</Strong></UnorderedListItem>


Копилот прав, это уже 2 лаба

danlla · 2026-02-26T10:39:32Z

CreditApplication.Gateway/LoadBalancing/WeightedRandomLoadBalancer.cs

+        foreach (var (service, weight) in weighted)
+        {
+            cumulative += weight;
+            if (roll < cumulative)


Здесь скорее всего лучше <=:

Теоретически самое большое значение у roll будет total, а самое большое значение у cumulative будет тоже total, то есть возможна ситуация когда cumulative == roll и неравенство не будет достигнуто

danlla · 2026-02-26T10:40:41Z

CreditApplication.Gateway/LoadBalancing/WeightedRandomLoadBalancer.cs

+public sealed class WeightedRandomLoadBalancer : ILoadBalancer
+{
+    private readonly IServiceDiscoveryProvider _serviceDiscovery;
+    private readonly IReadOnlyDictionary<string, double> _weights;
+
+    public WeightedRandomLoadBalancer(
+        IServiceDiscoveryProvider serviceDiscovery,
+        IReadOnlyDictionary<string, double> weights)
+    {
+        _serviceDiscovery = serviceDiscovery;
+        _weights = weights;
+    }


Использовать primary constructor

danlla · 2026-02-26T10:41:44Z

CreditApplication.Gateway/LoadBalancing/WeightedRandomLoadBalancer.cs

+        return new OkResponse<ServiceHostAndPort>(SelectByWeight(services).HostAndPort);
+    }
+
+    private Service SelectByWeight(IList<Service> services)


В этот приватный метод вряд ли будет передаваться что-то помимо List<Service>, так что для производительности можно этот тип явно и указать

danlla · 2026-02-26T10:50:10Z

CreditApplication.Gateway/Program.cs

+
+builder.Services.AddCors(options =>
+{
+    options.AddDefaultPolicy(policy =>


Тут копилот тоже прав, в ServiceDefaults есть AddDefaultPolicy, тут лучше задать именованную политику

danlla · 2026-02-26T10:55:46Z

CreditApplication.Gateway/Program.cs

+
+var weights = builder.Configuration
+    .GetSection("ReplicaWeights")
+    .Get<Dictionary<string, double>>() ?? new Dictionary<string, double>();


.Get<Dictionary<string, double>>() ?? [];

danlla · 2026-02-26T11:03:45Z

CreditApplication.AppHost/Program.cs

+var generator1 = builder.AddProject<Projects.CreditApplication_Generator>("generator-1")
+    .WithEndpoint("http", endpoint => endpoint.Port = 5101)
+    .WithReference(redis);
+
+var generator2 = builder.AddProject<Projects.CreditApplication_Generator>("generator-2")
+    .WithEndpoint("http", endpoint => endpoint.Port = 5102)
+    .WithReference(redis);
+
+var generator3 = builder.AddProject<Projects.CreditApplication_Generator>("generator-3")
+    .WithEndpoint("http", endpoint => endpoint.Port = 5103)
+    .WithReference(redis);


Всем генераторам стоит подождать redis

danlla · 2026-02-26T11:14:29Z

CreditApplication.AppHost/CreditApplication.AppHost.csproj

@@ -0,0 +1,25 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+<Sdk Name="Aspire.AppHost.Sdk" Version="9.0.0" />


Лучше явно прописать 9.5.2

danlla · 2026-02-26T11:27:40Z

CreditApplication.Generator/Program.cs

+
+var app = builder.Build();
+
+app.UseSerilogRequestLogging();


Serilog можно настроить так, чтобы он писал структурированные логи в aspire (Serilog.Sinks.OpenTelemetry)

danlla · 2026-02-26T11:31:54Z

CreditApplication.ServiceDefaults/CreditApplication.ServiceDefaults.csproj

+  </ItemGroup>
+
+  <ItemGroup>
+    <PackageReference Include="Microsoft.Extensions.Http.Resilience" Version="9.5.2" />


У этого пакета нет версии 9.5.2

dmgorshenin and others added 16 commits February 13, 2026 18:27

Update README.md

e1db504

Очистка кода

c0518fa

Update README.md

90ecc6e

Update README.md

8d9edea

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Исправил правки

85e73d2

Merge branch 'main' of https://github.com/dmgorshenin/cloud-development

9e1bd91

Забыл еще _logger убрать

7d74621

Лабораторная работа 2

089ed21

фикс правок

700e4da

Лабораторная 2

23f9ff6

еще один коммит на слияние

2f7c365

Update README.md

ec0ea34

Merge branch 'Lab2' of https://github.com/dmgorshenin/cloud-development…

f9ad2b3

… into Lab2

Format architectural diagram for better readability

229601e

Update README.md

757e46a

Copilot AI review requested due to automatic review settings February 18, 2026 12:36

github-actions bot added In progress Код в процессе проверки Lab 2 Лабораторная №2. Балансировка нагрузки labels Feb 18, 2026

github-actions bot requested a review from danlla February 18, 2026 12:36

Copilot started reviewing on behalf of dmgorshenin February 18, 2026 12:36 View session

Copilot AI reviewed Feb 18, 2026

View reviewed changes

danlla requested changes Feb 26, 2026

View reviewed changes

		@@ -0,0 +1,25 @@
		<Project Sdk="Microsoft.NET.Sdk">

		<Sdk Name="Aspire.AppHost.Sdk" Version="9.0.0" />

Conversation

dmgorshenin commented Feb 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants