Skip to content

[kernel-869] exclude files from extensions#98

Open
archandatta wants to merge 6 commits intomainfrom
archand/kernel-869/exclude-files-from-extensions
Open

[kernel-869] exclude files from extensions#98
archandatta wants to merge 6 commits intomainfrom
archand/kernel-869/exclude-files-from-extensions

Conversation

@archandatta
Copy link
Contributor

@archandatta archandatta commented Jan 28, 2026

Note

Medium Risk
Moderate risk because it changes the core ZipDirectory API and behavior (new filtering + walker error handling), which affects deployment and extension uploads and could unintentionally omit required files or alter zip contents.

Overview
Extension uploads now produce smaller, safer bundles. extensions upload zips directories with default exclusions (e.g., node_modules, .git, test/spec files, logs) and enforces a 50MB max bundle size, printing the resulting archive size and actionable guidance when exceeded.

Zipping API updated across the CLI. util.ZipDirectory now accepts optional ZipOptions for directory and filename-pattern exclusions and propagates directory-walk errors; all call sites (deploy, browsers extensions upload, etc.) are updated to pass nil or the new default options. Adds util.FormatBytes and new tests for zip exclusions and unzip behavior.

Written by Cursor Bugbot for commit 27ef5de. This will update automatically on new commits. Configure here.

@archandatta archandatta force-pushed the archand/kernel-869/exclude-files-from-extensions branch from a9498e8 to cf9bfed Compare January 28, 2026 13:44
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@archandatta archandatta requested a review from rgarcia January 28, 2026 14:15
Copy link
Contributor

@rgarcia rgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the pr! left some comments on naming, code duplication, and making the util more generic. main concerns are around duplicating the existing ZipDirectory function and making the exclusion options more intuitive.

@archandatta archandatta force-pushed the archand/kernel-869/exclude-files-from-extensions branch from 88b7410 to 27ef5de Compare February 4, 2026 15:02
@archandatta archandatta requested a review from rgarcia February 4, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants