Merged
Conversation
mattiaswal
force-pushed
the
add-yang-check
branch
2 times, most recently
from
a4a8635 to
4b8245c
Compare
mattiaswal
force-pushed
the
add-yang-check
branch
from
4b8245c to
4423bdb
Compare
Add input validation patterns to string-type leaves in container, firewall, DHCP, and interface YANG models. Also use mkdtemp() for temporary key files in keystore. Signed-off-by: Mattias Walström <lazzer@gmail.com>
This is a bug introduced in sysrepo 4.x
One change since -rc1 which was to drop shutdown debugging. For a full ChangeLog see https://github.com/finit-project/finit/releases/tag/4.16 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
curl's SCP/SFTP backend (libssh2) does not support interactive password prompting — it fails with an authentication error unless credentials are supplied non-interactively. Replace the curl path for SSH URIs with native scp(1), which inherits the TTY and prompts the user for a password as expected. Both scp:// and sftp:// URIs are handled by parsing the URI into a [user@]host:path argument. Port is extracted if present and passed via -P. If no user is embedded in the URI, the -u flag value (remote_user) is used instead. Host-key verification is skipped with -o StrictHostKeyChecking=no, the same trade-off already made by the test framework. When the destination URI ends with '/', a meaningful remote filename is derived from the source: the datastore's on-disk filename (e.g., startup-config.cfg), the datastore short-name for in-memory stores, or the source file's own basename for plain file copies. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit
force-pushed
the
add-yang-check
branch
from
4423bdb to
b3e158f
Compare
troglobit
approved these changes
Feb 27, 2026
Contributor
There was a problem hiding this comment.
Looks good! I've tested by upgrading on a system with containers and noticed no strange behavior, so very nice clean work on this!
I've rebased on latest main and snuck in two commits of my own:
- Update Finit to GA release, fixes shutdown debug messages
- Fix CLI
copycommand regression in scp/sftp to remote
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Tick relevant boxes, this PR is-a or has-a: