Don't forward CloseAbnormalClosure(1006) and CloseTLSHandshake(1015) as close frames#25
Open
ttjiaa wants to merge 1 commit intokoding:masterfrom
Open
Don't forward CloseAbnormalClosure(1006) and CloseTLSHandshake(1015) as close frames#25ttjiaa wants to merge 1 commit intokoding:masterfrom
CloseAbnormalClosure(1006) and CloseTLSHandshake(1015) as close frames#25ttjiaa wants to merge 1 commit intokoding:masterfrom
Conversation
…forwarded as close frame
seriousben
approved these changes
Jul 27, 2018
seriousben
left a comment
seriousben
left a comment
There was a problem hiding this comment.
Thanks, this will fix chrome complaining about reserved close code being sent.
|
The problem still exists |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where
CloseAbnormalClosure(1006) andCloseTLSHandshake(1015) are incorrectly forwarded as close frames, as they arereserved.Changes are made in correspondence to https://github.com/vulcand/oxy/blob/master/forward/fwd.go#L402-L418.
Ref: https://developer.mozilla.org/en-US/docs/Web/API/CloseEvent