Skip to content

Conversation

@aldas
Copy link
Contributor

@aldas aldas commented Feb 2, 2026

fix Static middleware listing all files from given filesystem root when browser=true

fixes: #2886

@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

❌ Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.06%. Comparing base (0954d6e) to head (c58cc50).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
middleware/static.go 70.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2887      +/-   ##
==========================================
+ Coverage   93.02%   93.06%   +0.04%     
==========================================
  Files          43       43              
  Lines        4456     4458       +2     
==========================================
+ Hits         4145     4149       +4     
+ Misses        194      193       -1     
+ Partials      117      116       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aldas aldas force-pushed the fix_static_mw_browse branch from 82d70a0 to c58cc50 Compare February 2, 2026 17:47
@aldas aldas merged commit 26ec148 into labstack:master Feb 2, 2026
6 of 7 checks passed
@aldas aldas deleted the fix_static_mw_browse branch February 2, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Static middleware Browse directory listing is not scoped to Root (WalkDir uses filesystem root)

1 participant