Skip to content

Conversation

@keelerm84
Copy link
Member

@keelerm84 keelerm84 commented Jan 30, 2026

Note

Medium Risk
Touches core data-source failover logic in FDv2 and changes a public/experimental config shape, which could affect initialization and fallback behavior across environments.

Overview
Updates DataSystemConfig and ConfigBuilder to replace the primary_synchronizer/secondary_synchronizer model with an ordered list of synchronizers, validating at least one synchronizer when set and updating contract-test config parsing accordingly.

Refactors FDv2 synchronizer execution to iterate/fallback across N synchronizers (including removal of permanently failing sources, index-based recovery to the first synchronizer, and an explicit directive to switch to the FDv1 fallback synchronizer), and updates/extends unit tests to cover the new API and behaviors. CI contract tests are also bumped to v3 v3.0.0-alpha.3 and YAML quoting is normalized.

Written by Cursor Bugbot for commit 9e2c297. This will update automatically on new commits. Configure here.

@keelerm84 keelerm84 requested a review from a team as a code owner January 30, 2026 22:25
@keelerm84 keelerm84 force-pushed the mk/sdk-1777/sync-list branch from e1a1a0e to 8da2666 Compare January 30, 2026 22:25
Copy link
Contributor

@jsonbailey jsonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a suggestion but don't consider it a blocker.

condition_func: Callable[[DataSourceStatus], bool]
) -> tuple[bool, bool]:
condition_func: Callable[[DataSourceStatus], ConditionDirective]
) -> tuple[bool, bool, ConditionDirective]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Ruby I ended up collapsing this down to a single result, essentially adding the remove sync and fallback as options of the Conditional Directive. From my understanding they are all independent of each other. If you have fallback, you don't care about the other two, if you have remove sync, you don't care about the conditional directive, so there isn't a need to have all three returned.

@keelerm84 keelerm84 force-pushed the mk/sdk-1777/sync-list branch from c62e0c3 to 9e2c297 Compare February 3, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants