Add basic fee estimation to on-chain wallet#585
Open
benthecarman wants to merge 3 commits intolightningdevkit:mainfrom
Open
Add basic fee estimation to on-chain wallet#585benthecarman wants to merge 3 commits intolightningdevkit:mainfrom
benthecarman wants to merge 3 commits intolightningdevkit:mainfrom
Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
benthecarman
force-pushed
the
on-chain-fee-estimation
branch
from
2c1a567 to
ef56520
Compare
tnull
reviewed
Jun 23, 2025
| /// a reasonable estimate from the configured chain source. | ||
| /// | ||
| /// [`BalanceDetails::total_anchor_channels_reserve_sats`]: crate::BalanceDetails::total_anchor_channels_reserve_sats | ||
| pub fn estimate_send_to_address( |
Collaborator
There was a problem hiding this comment.
Hmm, as discussed elsewhere, this is kind of an odd API as it is inherently TOCTOU race-y (based on fee rate updates, but also wallet state changes), and we don't offer any API that would allow to set exactly that net. fee returned here. I think generally the 'staging' approach as described over at #578 would be preferable, but that of course also interacts with UTXO locking, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #578
This adds basic fee estimation to the on-chain wallet. To not just completely copy-paste everything from
send_to_addressI refactored out a lot of the logic into its own function thatsend_to_addressnow uses. Then exposed the functionality and added it to tests.