removed good example from bad example#5
Open
tomByrer wants to merge 1 commit intolightscript:masterfrom
Open
Conversation
hard to tell which example is throwing the compile error Thanks for your project! :)
Contributor
|
Ahh, definitely. I think I'd like to show the "good" versions in separate blocks, so I may not merge this... |
rattrayalex
reviewed
Jul 15, 2017
| [0] | ||
|
|
||
| node | ||
| .children |
Contributor
There was a problem hiding this comment.
If you have a build running, you might try this and see what you think:
node
.children
[0] // oops!
<!-- -->
node
.children
[0]
Contributor
There was a problem hiding this comment.
this breaks them into separate blocks
Author
Contributor
There was a problem hiding this comment.
I'm guessing some non-ascii invisible whitespace snuck in there somehow?
Regardless, the <!-- --> is a separator used for markdown, not something intended to be part of the lightscript. If you look for it in other parts of the file you'll see how it's used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hard to tell which example is throwing the compile error
(hmmm, GitHub diffs are silly sometimes)
Thanks for your project! :)