Skip to content

Comments

Update favicons for light/dark mode contrast#223

Merged
patcapulong merged 1 commit intomainfrom
worktree-update-favicons
Feb 23, 2026
Merged

Update favicons for light/dark mode contrast#223
patcapulong merged 1 commit intomainfrom
worktree-update-favicons

Conversation

@patcapulong
Copy link
Contributor

Summary

  • Replace favicon SVGs with new transparent-background versions (no more solid background rects)
  • Fix light/dark mode mapping in docs.json so dark icon shows in light mode and light icon shows in dark mode for proper contrast

Test plan

  • Verified locally on localhost:3004 with light/dark mode toggle

Made with Cursor

Replace favicon SVGs with new versions that have no background rectangle
(transparent), and correct the docs.json config so light mode shows the
dark icon and dark mode shows the light icon for proper contrast.

Co-authored-by: Cursor <cursoragent@cursor.com>
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 23, 2026

Greptile Summary

Fixed favicon display by removing solid background rectangles from SVGs and correcting the light/dark mode mapping in docs.json. Previously, the config incorrectly showed dark icons in light mode and vice versa - now light mode displays favicon-light.svg and dark mode displays favicon-dark.svg for proper contrast.

  • Removed background <rect> elements from both favicon SVGs for transparent backgrounds
  • Swapped favicon mapping in docs.json to match mode names correctly
  • Made minor coordinate adjustments to the SVG paths

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • Simple visual update to favicon files with straightforward config fix - no logic changes, no runtime behavior affected
  • No files require special attention

Important Files Changed

Filename Overview
mintlify/docs.json Fixed favicon mapping so light mode uses light icon and dark mode uses dark icon for proper contrast
mintlify/favicon-dark.svg Removed solid background rect and adjusted path coordinates for transparent background
mintlify/favicon-light.svg Removed solid background rect and adjusted path coordinates for transparent background

Last reviewed commit: 902cefb

@patcapulong patcapulong merged commit 2aafcdf into main Feb 23, 2026
6 checks passed
@patcapulong patcapulong deleted the worktree-update-favicons branch February 23, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants