#63. Dynamometer does not support negative block id's#66
Open
jojochuang wants to merge 1 commit intolinkedin:masterfrom
Open
#63. Dynamometer does not support negative block id's#66jojochuang wants to merge 1 commit intolinkedin:masterfrom
jojochuang wants to merge 1 commit intolinkedin:masterfrom
Conversation
Collaborator
|
Great find, thanks @jojochuang ! And sorry for the delay in my response. I think the current logic is a little more verbose than necessary, can we just use Math#floorMod()? |
Collaborator
|
Hey @jojochuang , I put up a patch using Also cc @fengnanli |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #63
Submitted the PR on behalf of @fangyurao. The PR was adopted from this commit: fangyurao@0f077a6