bookmarks and links in news: replace flags with language description in French#296
bookmarks and links in news: replace flags with language description in French#296Trim wants to merge 7 commits intolinuxfrorg:masterfrom
Conversation
|
I've just seen there's a little thing to adjust: when we add a link in the redaction, the text "en allemand" is only shown after a page reload. That's not blocking, but I think I'll have time today to fix it. |
Ok, I've just made changes on the CoffeeScript side, it works on my development environment, but it's first time I create a new I've tried to run |
- missing class to display flag on bookmarks during preview - missing flags in some contrib CSS - reorder langs in Redis to default to 'xx' (then 'fr', then sorted)
Trim
force-pushed
the
link-without-flags
branch
from
139a102 to
2da99e6
Compare
| def lang_and_hit(link) | ||
| detail = "(" | ||
| detail += "en #{Lang[link.lang].downcase}, " unless link.lang == 'fr' | ||
| detail += "#{pluralize link.nb_clicks, 'clic'})" |
There was a problem hiding this comment.
| detail += "#{pluralize link.nb_clicks, 'clic'})" | |
| detail += pluralize link.nb_clicks, 'clic' | |
| detail += ')' |
There was a problem hiding this comment.
Les ' plutôt que les " c'est supposé être plus sympa pour l'interpréteur ruby, notamment côté mémoire, mais bon, ça joue ptet pas beaucoup non plus.
| # encoding: UTF-8 | ||
| module LinkHelper | ||
| def lang_and_hit(link) | ||
| detail = "(" |
There was a problem hiding this comment.
| detail = "(" | |
| detail = '(' |
|
Avec #383 , nous allons supprimer |
|
Je ferme cette PR, parce qu'elle entre en conflit avec #383 qui supprime les fichiers |
3 participants
As discussed in these two suivis:
For links in news, it adds French language description before the hit counter if Language is not French.
For bookmarks, it does the same and it removes too the useless
<ul>HTML tag and directly set content with the link and the French language description.