Skip to content

iOS/macOS audio updates #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hiroshihorie wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

iOS/macOS audio updates #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"@eslint/compat": "^1.3.2",
"@eslint/eslintrc": "^3.3.1",
"@eslint/js": "^9.35.0",
"@livekit/react-native-webrtc": "^137.0.2",
"@livekit/react-native-webrtc": "link:../react-native-webrtc",
"@react-native/babel-preset": "0.83.0",
"@react-native/eslint-config": "0.83.0",
"@release-it/conventional-changelog": "10.0.1",
Expand Down
7 changes: 5 additions & 2 deletions src/components/VideoTrack.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,16 @@
RTCView,
RTCPIPView,
type RTCIOSPIPOptions,
} from '@livekit/react-native-webrtc';

Check failure on line 18 in src/components/VideoTrack.tsx

View workflow job for this annotation

GitHub Actions / test 

Cannot find module '@livekit/react-native-webrtc' or its corresponding type declarations.
import {
forwardRef,
useCallback,
useEffect,
useMemo,
useState,
type ForwardRefExoticComponent,
type ReactNode,
type RefAttributes,
} from 'react';
import { RemoteVideoTrack } from 'livekit-client';
import ViewPortDetector from './ViewPortDetector';
Expand Down Expand Up @@ -132,7 +134,9 @@
* @returns A React component that renders the given video track.
* @public
*/
export const VideoTrack = forwardRef<RTCViewInstance, VideoTrackProps>(
export const VideoTrack: ForwardRefExoticComponent<
VideoTrackProps & RefAttributes<RTCViewInstance>
> = forwardRef<RTCViewInstance, VideoTrackProps>(
(
{
style = {},
Expand Down Expand Up @@ -224,8 +228,7 @@
objectFit={objectFit}
zOrder={zOrder}
mirror={mirror}
// TODO: fix this up in react-native-webrtc side.
// @ts-expect-error

Check failure on line 231 in src/components/VideoTrack.tsx

View workflow job for this annotation

GitHub Actions / test 

Unused '@ts-expect-error' directive.
iosPIP={iosPIP}
ref={ref}
/>
Expand Down
12 changes: 11 additions & 1 deletion src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
import 'well-known-symbols/Symbol.asyncIterator/auto';
import 'well-known-symbols/Symbol.iterator/auto';
import './polyfills/MediaRecorderShim';
import { registerGlobals as webrtcRegisterGlobals } from '@livekit/react-native-webrtc';
import {
registerGlobals as webrtcRegisterGlobals,
AudioDeviceModule,
AudioEngineMuteMode,
AudioEngineAvailability,
audioDeviceModuleEvents,
} from '@livekit/react-native-webrtc';

Check failure on line 10 in src/index.tsx

View workflow job for this annotation

GitHub Actions / test 

Cannot find module '@livekit/react-native-webrtc' or its corresponding type declarations.
import { setupURLPolyfill } from 'react-native-url-polyfill';
import './polyfills/EncoderDecoderTogether.min.js';
import AudioSession, {
Expand Down Expand Up @@ -164,6 +170,10 @@

export {
AudioSession,
AudioDeviceModule,
AudioEngineMuteMode,
AudioEngineAvailability,
audioDeviceModuleEvents,
RNE2EEManager,
RNKeyProvider,
AndroidAudioTypePresets,
Expand Down
8 changes: 7 additions & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3308,6 +3308,12 @@ __metadata:
languageName: node
linkType: hard

"@livekit/react-native-webrtc@link:../react-native-webrtc::locator=%40livekit%2Freact-native%40workspace%3A.":
version: 0.0.0-use.local
resolution: "@livekit/react-native-webrtc@link:../react-native-webrtc::locator=%40livekit%2Freact-native%40workspace%3A."
languageName: node
linkType: soft

"@livekit/react-native-webrtc@npm:^137.0.2":
version: 137.0.2
resolution: "@livekit/react-native-webrtc@npm:137.0.2"
Expand All @@ -3331,7 +3337,7 @@ __metadata:
"@eslint/js": ^9.35.0
"@livekit/components-react": ^2.9.17
"@livekit/mutex": ^1.1.1
"@livekit/react-native-webrtc": ^137.0.2
"@livekit/react-native-webrtc": "link:../react-native-webrtc"
"@react-native/babel-preset": 0.83.0
"@react-native/eslint-config": 0.83.0
"@release-it/conventional-changelog": 10.0.1
Expand Down
Loading