Skip to content

Conversation

@theomonnom
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2026

⚠️ No Changeset found

Latest commit: 52062a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.


message CreateSimulationRunRequest {
string agent_name = 1;
string agent_description = 2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add comments on each field on what they are for?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do I create a simulation with existing personas/scenarios?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scenarios aren't implemented yet

}

service AgentSimulationService {
rpc CreateSimulationRun(CreateSimulationRunRequest) returns (CreateSimulationRunResponse);
Copy link
Member

@davidzhao davidzhao Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already in simulation service

Suggested change
rpc CreateSimulationRun(CreateSimulationRunRequest) returns (CreateSimulationRunResponse);
rpc CreateRun(CreateSimulationRunRequest) returns (CreateSimulationRunResponse);

Copy link
Member Author

@theomonnom theomonnom Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep Simulation there tbh, no strong opinion tho

@theomonnom theomonnom requested a review from davidzhao February 11, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants