-
Notifications
You must be signed in to change notification settings - Fork 124
add livekit_agent_simulation service #1404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
|
||
| message CreateSimulationRunRequest { | ||
| string agent_name = 1; | ||
| string agent_description = 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add comments on each field on what they are for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do I create a simulation with existing personas/scenarios?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scenarios aren't implemented yet
| } | ||
|
|
||
| service AgentSimulationService { | ||
| rpc CreateSimulationRun(CreateSimulationRunRequest) returns (CreateSimulationRunResponse); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already in simulation service
| rpc CreateSimulationRun(CreateSimulationRunRequest) returns (CreateSimulationRunResponse); | |
| rpc CreateRun(CreateSimulationRunRequest) returns (CreateSimulationRunResponse); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep Simulation there tbh, no strong opinion tho
No description provided.