Redact ice server credentials in logs #1408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e092f0d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
boks1971
approved these changes
Feb 11, 2026
| repeated string urls = 1; | ||
| string username = 2; | ||
| string credential = 3; | ||
| string username = 2 [ |
Contributor
There was a problem hiding this comment.
Might be okay to not do this for "username"?
Contributor
Author
There was a problem hiding this comment.
We started redacting user and participant names in other places, particularly SIP and io. I think usernames should generally be redacted.
paulwe
approved these changes
Feb 11, 2026
protobufs/livekit_rtc.proto
Outdated
| string credential = 3; | ||
| string username = 2 [ | ||
| (logger.redact) = true, | ||
| (logger.redact_format) = "<redacted ({{ .Size }} bytes)>" |
Contributor
There was a problem hiding this comment.
we only care about size for metadata columns...
Contributor
Author
There was a problem hiding this comment.
Removed redact_format entries (we do have them in other places where we redact username/pwd though)
…logs' into benjamin/redact_ice_credentials_logs
shreyasj-livekit
pushed a commit
that referenced
this pull request
Feb 11, 2026
--------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix part of https://github.com/livekit/livekit/security/code-scanning/33