This repository was archived by the owner on Aug 7, 2025. It is now read-only.
Updated script to generate feature catalog files#1735
Open
Conversation
…a for feature files
|
🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1735.surge.sh 🎊 |
silv-io
approved these changes
Apr 17, 2025
Member
silv-io
left a comment
silv-io
left a comment
There was a problem hiding this comment.
LGTM! I think it is good for those two things to be more explicitly defined
| feature_name = f'[{feature_name}]({documentation_page})' | ||
| status = feature.get('status', DEFAULT_STATUS) | ||
| aws_docs_url = feature.get('aws_documentation_url') | ||
| if aws_docs_url: |
Member
There was a problem hiding this comment.
comment: Since you've made it required in the schema you theoretically won't need this check in there anymore. But I guess it's good to stay defensive :D
Collaborator
|
Hey @k-a-il! I just realized that engineers can merge docs PRs themselves and that we don't have the permission settings setup to require DevRel/Docs maintainers review/sign off. 😸 Just a heads up, that's not the right process. 🙂 Moving forward, I'll need to update the codeowners file likely... but please make sure:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Updated script according to changes in JSON schmea file for features files from this PR
documentation_pagetoaws_documentation_url