Fix for add token base on id - w.r.t. original file#766
Fix for add token base on id - w.r.t. original file#766prajyotsji wants to merge 2 commits intoloopj:masterfrom
Conversation
|
Why do you open these PR's? For what? |
|
@korun Hi, I'm using the js lib in one of my projects. I was facing issue with token 'C++' this works well with the forked js. But add token(append) had issue. |
|
So, can you provide some descriptions for your PR's? |
|
Yes, thank you for your time. The reason to include the forked js lib was because there was no 'C++' or special characters returned in original file. for add_token function Line : 655 - existing_data - returned me object with id and name - Object {id: "3", name: "Name"} This was just a quick fix from my side to make the js in project working and it works fine currently as per my requirement. If you may please suggest some changes if it is not correctly done, or is there any other way I can use this plugin in my project. As the changes were made only because of 'C++'. It would be very helpful. :) |
|
I can't reproduce your bug. |
fd2316b to
8a8390e
Compare
No description provided.