Conversation
|
I'm glad I waited a bit longer to make a review, the docs look excellent! I'll try to get a review out today, maybe before our meeting, but no promises |
bicknrown
left a comment
There was a problem hiding this comment.
overall quite thorough, as far as i can tell, just some minor formatting/linting things and i'll be happy.
thank you for your effort!
|
the branch is also out of date with |
emilkovacev
left a comment
There was a problem hiding this comment.
Superb documentation and commenting! I have but a few small suggestions – the tests run smoothly and qemu still runs well after these changes.
emilkovacev
left a comment
There was a problem hiding this comment.
Everything appears to be in order!
Requested minor (non functionality changes). No response since June. Approved by others.
gcc makes things so difficult
|
LGTM! |
Description
Provides a way to interact with page tables and directories.
Also identity maps the first 12MiB.
Note: does not do allocation or anything that requires it. Intended for separate PR
Issue #28
Type of change
Testing
Existing tests all pass.
In addition, tests were added to verify the identity paging is valid.
And for translation of virtual address to physical address.
And for swapping the active page directory.
Test Configuration:
Checklist: