implement Fonts service

[andrewharvey]

https://docs.mapbox.com/api/maps/fonts/

getFontGlyphRange still exists in Styles, which I suggest we do for backwards compatibility. However this means this method is now duplicate in the code base. So we can either:

• leave this duplicated, existing in both Fonts and Styles services
• omit it from the Fonts service
• mark as deprecated in Styles service, leaving duplicated code, but giving a path for future removal.

[andrewharvey]

• I found in some cases I needed to pass fresh=true to listFonts, though at the moment I'm not sure if that forces the cache bypass, or I was just lucky that a new URL resulted in a cache miss and retrieved the latest font list. Needs more testing to understand if this query parameter is actually interpreted.

[andrewharvey]

By the way, I needed this for https://gist.github.com/andrewharvey/ff5e2c15b8a60249a593dc189192eb02 which reports

• fonts used within an account
• which fonts each Style is using
• which Styles are using each font (useful for knowing which fonts you can clear out of your account to keep under the 100 fonts limit)
• which fonts Styles are using that aren't in your account (or standard Mapbox fonts) - useful if you've accidentally deleted a font from your account that was in use

[andrewharvey]

@katydecorah interested in reviewing?

[katydecorah]

👋 @andrewharvey I shared this PR with the team that works on Fonts API and they'll have someone take a look (hopefully this week)!

[jseppi]

Thanks for this contribution, @andrewharvey! The one bug I found during review is that the verb used in the putFont method should be POST. The rest of my comments are suggestions around consistency and usability.

Also, I see that there's an existing font method in the styles client: Styles.getFontGlyphRange -- would you mind deleting that one and the associated tests since this PR puts that method in a more appropriate place?

[jseppi]

For consistency with how this method is documented in our public docs, could you rename the method to addFont? https://docs.mapbox.com/api/maps/fonts/#add-a-font

[andrewharvey]

In docs/development.md it says to use "create" for POST requests, do you think it should still be addFont or createFont?

[jseppi]

👍 createFont is a good suggestion for consistency

[jseppi]

Since we know that end is always start + 255, we could make this method a little more ergonomic by only requiring the start parameter. Then, we'd just add 255 to it to come up with the correct fileName:

var fileName = config.start + '-' + (config.start + 255) + '.pbf';

[andrewharvey]

Must end always equal start+255 or could users still request a larger slice?

[jseppi]

Yup, end must always be start + 255

[jseppi]

Ah, sorry I got the syntax wrong in my review suggestion, @andrewharvey, which is why tests are failing. Should be:

v.required(v.oneOf(['public', 'private']))