Add tests for room creators being able to join v12 room that everyone has left#843
Draft
MadLittleMods wants to merge 1 commit intomainfrom
Draft
Add tests for room creators being able to join v12 room that everyone has left#843MadLittleMods wants to merge 1 commit intomainfrom
MadLittleMods wants to merge 1 commit intomainfrom
Conversation
35 tasks
Member
|
Presumably v12 is special because historically Synapse would use the domain in the room ID as a last-ditch server to join via? |
MadLittleMods
commented
Feb 16, 2026
| @@ -52,6 +52,26 @@ func TestMSC4289PrivilegedRoomCreators(t *testing.T) { | |||
| ) | |||
| } | |||
|
|
|||
Collaborator
Author
There was a problem hiding this comment.
Presumably v12 is special because historically Synapse would use the domain in the room ID as a last-ditch server to join via?
I wouldn't expect this to work in other room versions (unless you backdate events to rollback state).
But for v12, the room creator has ultimate power to do whatever and so should be able to send a m.room.mebership to join again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for room creators being able to join v12 room that everyone has left
Spawning from discussion with @ara4n where we both thought this kind of thing should work.
Both tests fail with Synapse:
❌
POST http://127.0.0.1:33116/_matrix/client/v3/join/{roomId}->404 Not Foundwith{"errcode":"M_UNKNOWN","error":"Can't join remote room because no servers that are in the room have been provided."}Pull Request Checklist