Skip to content

fix: accessibility issue with slider ariaLabelledBy#1983

Merged
gjulivan merged 3 commits intomendix:mainfrom
DiljohnSingh:fix/Accessibility-issue-slider-ariaLabelledBy
Feb 18, 2026
Merged

fix: accessibility issue with slider ariaLabelledBy#1983
gjulivan merged 3 commits intomendix:mainfrom
DiljohnSingh:fix/Accessibility-issue-slider-ariaLabelledBy

Conversation

@DiljohnSingh
Copy link
Contributor

Pull request type

Bug fix (non-breaking change which fixes an issue)

Screenshot 2025-11-14 at 12 27 36

Description

  • Team discovered an accessibility issue with slider. Slider handle is not linked to the label
  • Added the missing aria-labelledby using the id provided
  • Updated the snapshots

What should be covered while testing?

  • You should see aria-labelledby with the same value as id of associated label component.
  • Test cases should be passing.
  • Turn on Screen reader and navigate to handle on any slider. It should announce the label text.

@DiljohnSingh DiljohnSingh requested a review from a team as a code owner November 14, 2025 11:33
@DiljohnSingh DiljohnSingh force-pushed the fix/Accessibility-issue-slider-ariaLabelledBy branch 4 times, most recently from 655b5e6 to b46e536 Compare December 2, 2025 09:05
@DiljohnSingh DiljohnSingh force-pushed the fix/Accessibility-issue-slider-ariaLabelledBy branch from b46e536 to 18cf572 Compare December 31, 2025 12:25
@DiljohnSingh DiljohnSingh force-pushed the fix/Accessibility-issue-slider-ariaLabelledBy branch from ce50789 to 91da86b Compare January 7, 2026 17:16
HedwigAR
HedwigAR previously approved these changes Jan 8, 2026
leonardomendix
leonardomendix previously approved these changes Feb 18, 2026
gjulivan
gjulivan previously approved these changes Feb 18, 2026
@gjulivan gjulivan force-pushed the fix/Accessibility-issue-slider-ariaLabelledBy branch from cdef5a1 to fc4af9d Compare February 18, 2026 12:26
@gjulivan gjulivan dismissed stale reviews from leonardomendix and themself via 6921b58 February 18, 2026 12:33
@gjulivan gjulivan enabled auto-merge (rebase) February 18, 2026 12:34
@gjulivan gjulivan merged commit 38c2cc2 into mendix:main Feb 18, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments