Open
Conversation
r0b1n
reviewed
Feb 13, 2026
packages/pluggableWidgets/barcode-generator-web/src/config/Barcode.config.ts
Outdated
Show resolved
Hide resolved
yordan-st
force-pushed
the
barcode-widget
branch
from
b29d73e to
67fca75
Compare
- remove unnecessary context, use props instead - split config, make it more typed - add class and style to the widget - remove unnecessary hooks, use simple utils instead - update icons and tiles
- hide ean128 for qrcode - change code value to expression - add button position and card view config - implement layout, styling and icon
- static value consistency checks - dynamic value warnings and runtime error alert
- enable displayValue for addons - improve conditional visibility for certain configurations - improve descriptions
- added svg assets for barcode preview - add asset resolver for image sources - encapsulate svg logic into hook - cleaner main preview component
yordan-st
force-pushed
the
barcode-widget
branch
from
d40907a to
21331d1
Compare
yordan-st
force-pushed
the
barcode-widget
branch
from
21331d1 to
086c244
Compare
r0b1n
reviewed
Feb 18, 2026
| return ( | ||
| <div className="barcode-renderer"> | ||
| <div className="alert alert-danger" role="alert"> | ||
| <strong>Barcode Error:</strong> {error} |
Collaborator
There was a problem hiding this comment.
I think the error messages (I see them in config/validation.ts) are more targeted to the developers, like EAN-13 requires 12 or 13 numeric digits (12 data digits + optional checksum).. So they make less sense for the end user, they are likely not in control of this even. So a more generic error would be better.
r0b1n
reviewed
Feb 18, 2026
| return ( | ||
| <div className="barcode-renderer"> | ||
| {restProps.buttonPosition === "top" && downloadButton} | ||
| <div className="barcode-preview-barcode-container" style={{ height: displayHeight }}> |
Collaborator
There was a problem hiding this comment.
We want to have the same DOM structure and class names in both, preview and real world. Ideally, via react components reuse, but reuse can introduce additional complexity we don't always want, so it should be reasonable effort.
Bit having different classes defeats the purpose of design preview, we don't want to maintain two different stylesheets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
New feature (non-breaking change which adds functionality)\
Description