Fixed No battery reading on Heltec Wireless Paper 1.2 companion #1262 #1264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added pyMC_core to meshcore projects mentioned Cisien's meshcoretomqtt fork from Andrew-a-g updated Coding Rate explanation and recommendation updated radio presets and added how to update presets listed in the app
Update faq.md
…t c->push_failures
Fix debug log: use c->extra.room.push_failures instead of c->push_failures
Change source of truth to this repo, remove whitespace
# Conflicts: # docs/payloads.md
|
Should the changes to |
Author
|
Code is check and ready. No changes in README and docs. |
|
If I look at https://github.com/meshcore-dev/MeshCore/pull/1264/files I do see files changed outside of |
|
I can confirm that building with the changes in |
Author
|
My changes was only in variants directory. |
Contributor
|
I confirm that the changes in the variants files fix the battery reading for heltec Wireless Paper v1.2. The changes to the other files should be discarded, must have been added to this PR in error. |
|
I made a way simpler fix here #1584 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
variant for Heltec Wireless Paper v1.2