Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7836 +/- ##
==========================================
- Coverage 59.87% 58.88% -1.00%
==========================================
Files 352 352
Lines 31872 31884 +12
==========================================
- Hits 19083 18774 -309
- Misses 12789 13110 +321 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jenshnielsen
force-pushed
the
ty_support_2025
branch
5 times, most recently
from
0f99498 to
fcd882f
Compare
jenshnielsen
force-pushed
the
ty_support_2025
branch
from
fcd882f to
193d9fa
Compare
This is a breaking change since root_instrument is now abstract on InstrumentBase and must be implemented in a subclass
jenshnielsen
force-pushed
the
ty_support_2025
branch
from
1646c57 to
5186cb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a branch of various fixes to try to enable ty support for type checking. The aim is not to land this branch directly but to cherrypick thigs from it. Along with improvments to ty that will hopefully get things working along the way