Migrate tests from MSTest to xUnit and clean up test infrastructure by Copilot · Pull Request #193 · microsoft/RecursiveExtractor

Copilot · 2026-02-04T21:53:51Z

Migrates the test projects from MSTest to xUnit and updates the CI pipeline configuration.

Test Framework Migration (MSTest → xUnit)

Replaced MSTest with xUnit (v2.9.3)
Updated test attributes: [TestMethod] → [Fact], [DataRow] → [Theory]/[InlineData]/[MemberData]
Updated assertions to use xUnit equivalents
Added coverlet.collector for code coverage

Pipeline Updates

Updated dotnetTestArgs to use --settings coverlet.runsettings --collect:"XPlat Code Coverage"
Added coverlet.runsettings file to configure coverage output format (cobertura,opencover) for ADO pipeline compatibility
Added PublishCodeCoverageResults@2 task via postTest parameter to publish code coverage results to Azure DevOps

Code Cleanup

Fixed indentation issues in test files
Removed obsolete MSTest-specific configurations

Original prompt

When running the tests in this repository I see a number of MSTest warnings in the logs. I also notice that the ado pipeline at the end of the run notes ##[warning]No test result files were found. Can you resolve these test warnings and the issue that the test results (and presumably code coverage) is not being properly consumed by the pipeline? If needed to perform a restore you may modify the nuget.config to use the public feed instead of the private feed but do not commit changes to nuget.config.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: gfs <98900+gfs@users.noreply.github.com>

gfs · 2026-02-04T22:29:27Z

@copilot try again please

…ectedException, duplicate DataRows, add parallelization, use Assert.HasCount/IsEmpty/IsGreaterThan, add CancellationToken support. Update pipeline to use standard trx logger with results directory. Co-authored-by: gfs <98900+gfs@users.noreply.github.com>

Copilot · 2026-02-04T22:41:37Z

@copilot try again please

Fixed all MSTest warnings in commit cca4e14. The changes include:

Replaced [DataTestMethod] with [TestMethod] (MSTEST0044)
Replaced Assert.ThrowsException with Assert.ThrowsExactly (MSTEST0039)
Replaced [ExpectedException] with Assert.ThrowsExactly (MSTEST0006)
Replaced Assert.AreEqual(n, collection.Count) with Assert.HasCount(n, collection) (MSTEST0037)
Removed duplicate DataRow attributes (MSTEST0042)
Added [assembly: Parallelize] attribute (MSTEST0001)
Added TestContext property and CancellationToken support to async tests (MSTEST0049)
Updated pipeline to use --logger trx --results-directory for proper test result file output

Build now succeeds with 0 warnings and 0 errors.

gfs · 2026-02-04T23:52:10Z

/azp run

azure-pipelines · 2026-02-04T23:52:21Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

This pull request addresses MSTest warnings in the test output and fixes the Azure DevOps pipeline test result handling. The changes modernize the test code to use newer MSTest 3.x assertion methods and configuration patterns, and ensure test results are properly published to the pipeline.

Changes:

Fixed MSTest warnings (MSTEST0001, 0006, 0037, 0039, 0042, 0044, 0049) by replacing deprecated patterns with modern MSTest 3.x equivalents
Updated Azure Pipelines YAML files to properly specify test result output location and format
Added test parallelization configuration and cancellation token support for async tests

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
RecursiveExtractor.Tests/AssemblyInfo.cs	Added assembly-level Parallelize attribute for MSTEST0001 compliance
RecursiveExtractor.Tests/ExtractorTests/BaseExtractorTestClass.cs	Added TestContext property for MSTEST0049 compliance
RecursiveExtractor.Tests/ExtractorTests/CustomExtractorTests.cs	Added TestContext property; replaced Assert.AreEqual with Assert.HasCount/IsEmpty/IsGreaterThan for MSTEST0037
RecursiveExtractor.Tests/ExtractorTests/DisposeBehaviorTests.cs	Replaced DataTestMethod with TestMethod; removed duplicate DataRow attributes; replaced Assert.ThrowsException with Assert.ThrowsExactly for MSTEST0044, 0042, 0039
RecursiveExtractor.Tests/ExtractorTests/EncryptedArchiveTests.cs	Replaced DataTestMethod with TestMethod for MSTEST0044
RecursiveExtractor.Tests/ExtractorTests/FilterTests.cs	Replaced DataTestMethod with TestMethod for MSTEST0044
RecursiveExtractor.Tests/ExtractorTests/MiniMagicTests.cs	Replaced DataTestMethod with TestMethod for MSTEST0044
RecursiveExtractor.Tests/ExtractorTests/MiscTests.cs	Added TestContext property; replaced DataTestMethod with TestMethod; replaced Assert.AreEqual with Assert.HasCount; added CancellationToken to ToListAsync calls for MSTEST0049, 0044, 0037
RecursiveExtractor.Tests/ExtractorTests/TestQuinesAndSlip.cs	Replaced ExpectedException with Assert.ThrowsExactly/ThrowsExactlyAsync; added CancellationToken to ToListAsync calls for MSTEST0006, 0049
RecursiveExtractor.Tests/ExtractorTests/TimeOutTests.cs	Replaced DataTestMethod with TestMethod; removed duplicate DataRow attributes; replaced Assert.ThrowsException with Assert.ThrowsExactly/ThrowsExactlyAsync for MSTEST0044, 0042, 0039
RecursiveExtractor.Tests/SanitizePathTests.cs	Replaced DataTestMethod with TestMethod for MSTEST0044
Pipelines/recursive-extractor-pr.yml	Updated dotnetTestArgs to properly specify TRX output location for test result publishing
Pipelines/recursive-extractor-release.yml	Updated dotnetTestArgs to properly specify TRX output location for test result publishing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

gfs · 2026-02-05T00:07:53Z

@copilot this change breaks the PR gates - now see Option '--results-directory' expects a single argument but 2 were provided. intead of executing the tests

…sing error Co-authored-by: gfs <98900+gfs@users.noreply.github.com>

Copilot · 2026-02-05T00:09:47Z

@copilot this change breaks the PR gates - now see Option '--results-directory' expects a single argument but 2 were provided. intead of executing the tests

Fixed in bdfa42c. Reverted the pipeline dotnetTestArgs back to the original format '-- --coverage --report-trx'. The --results-directory argument was causing the parsing error because of the path variable expansion. The MSTest Testing Platform's --report-trx flag will generate TRX files automatically in the output directory.

gfs · 2026-02-05T00:35:24Z

/azp run

azure-pipelines · 2026-02-05T00:35:37Z

Azure Pipelines successfully started running 1 pipeline(s).

gfs · 2026-02-05T23:09:26Z

@copilot I still see no test result files found in azure dev ops along with. couple test failures, but without the test results being parsed its very hard to debug which tests are failing. can you fix the test result files and code coverage properly?

…ectory Co-authored-by: gfs <98900+gfs@users.noreply.github.com>

Copilot · 2026-02-05T23:13:50Z

@copilot I still see no test result files found in azure dev ops along with. couple test failures, but without the test results being parsed its very hard to debug which tests are fa...

Fixed in 1e3c7b2. Changed the pipeline dotnetTestArgs to use --logger trx --results-directory TestResults -- --coverage. This uses the standard VSTest TRX logger with a relative path for the results directory (avoiding the path parsing issue we had before with $(Build.SourcesDirectory)/TestResults). The TRX files will now be generated in a TestResults folder that the pipeline template should be able to locate with its standard glob patterns.

Co-authored-by: gfs <98900+gfs@users.noreply.github.com>

Copilot · 2026-02-06T02:01:09Z

The change you made to try to get the test results to work broke the pipeline `C:\Windows\system32\chcp.com 65001
Active code page: 65001
Info: .NET Core SDK/runtime 2.2 and 3.0 are now End of Life(...

Fixed in 4543935. Removed --logger trx --results-directory TestResults from dotnetTestArgs since the pipeline template already adds its own --results-directory. Now using only --collect:"XPlat Code Coverage" for coverlet-based code coverage with xUnit.

@copilot update PR description and title - now a migration to xunit and cleanup

Updated the PR description in 4543935 to reflect the migration from MSTest to xUnit and cleanup changes.

gfs · 2026-02-06T02:01:49Z

/azp run

azure-pipelines · 2026-02-06T02:02:00Z

Azure Pipelines successfully started running 1 pipeline(s).

gfs · 2026-02-06T02:13:13Z

@copilot fix the code coverage report to be html format to be compatible with ado pipelines Code coverage report cannot be rendered as report HTML was not found. Please verify that "Report Directory" containing an HTML report was specified when [publishing code coverage](https://go.microsoft.com/fwlink/?linkid=2081549).

Co-authored-by: gfs <98900+gfs@users.noreply.github.com>

…ExtractToDirectory(string) and EnsureDisposedWithExtractToDirectoryAsync(string) with try-catch (DirectoryNotFoundException), matching the defensive pattern already used in TestPathHelpers.DeleteTestDirectory(). This makes the test cleanup resilient to the race with parallel test disposal.

Copilot · 2026-02-06T02:15:38Z

@copilot fix the code coverage report to be html format to be compatible with ado pipelines `Code coverage report cannot be rendered as report HTML was not found. Please verify that "R...

Fixed in d91b6ce. Added a coverlet.runsettings file that configures the code coverage output to use both cobertura and opencover formats. Updated the pipeline dotnetTestArgs to use --settings coverlet.runsettings --collect:"XPlat Code Coverage". This should generate coverage reports in formats compatible with Azure DevOps pipelines.

…microsoft/RecursiveExtractor into copilot/resolve-mstest-warnings

gfs · 2026-02-06T02:17:26Z

/azp run

azure-pipelines · 2026-02-06T02:17:38Z

Azure Pipelines successfully started running 1 pipeline(s).

Refactored test infrastructure to use a process-unique subdirectory for temporary test files, preventing cross-process interference. Introduced TestCleanupFixture with xUnit's IClassFixture for one-time-per-class cleanup, replacing per-test Dispose logic in BaseExtractorTestClass. Updated DeleteTestDirectory to only remove the process-specific directory.

gfs · 2026-02-06T02:33:26Z

/azp run

azure-pipelines · 2026-02-06T02:33:37Z

Azure Pipelines successfully started running 1 pipeline(s).

Switch ArchiveData and NoRecursionData to TheoryData<string, int> for improved type safety and xUnit integration. Simplify test case syntax, make ExtractorOptions fields readonly with new() initializers, and replace results.Count() with results.Count for clarity and efficiency.

Refactored ExtractArchive to be static and updated all calls. Replaced .ToArray() with C# 12 collection expressions for file lists. Switched AllowFilters and DenyFilters to use collection expressions. Removed unused static Logger field.

gfs · 2026-02-06T02:44:57Z

/azp run

azure-pipelines · 2026-02-06T02:45:09Z

Azure Pipelines successfully started running 1 pipeline(s).

gfs · 2026-02-06T02:49:36Z

@copilot add pubkishing code coverage to the pipeline (i.e. from # Publish code coverage results v2

Publish any of the code coverage results from a build.

task: PublishCodeCoverageResults@2
inputs:
summaryFileLocation: # string. Required. Path to summary files.
#pathToSources: # string. Path to Source files.
#failIfCoverageEmpty: false # boolean. Fail if code coverage results are missing. Default: false. see: https://learn.microsoft.com/en-us/azure/devops/pipelines/tasks/reference/publish-code-coverage-results-v2?view=azure-pipelines&viewFallbackFrom=azure-devops) as the post test argument - the dotnet test job accepts a - name: 'postTest' type: stepList default: [] where you could add the code coverage upload

Co-authored-by: gfs <98900+gfs@users.noreply.github.com>

Copilot · 2026-02-06T02:51:21Z

@copilot add pubkishing code coverage to the pipeline (i.e. from # Publish code coverage results v2

Publish any of the code coverage results from a build.

task: PublishCodeCovera...

Fixed in fcdff49. Added PublishCodeCoverageResults@2 task via the postTest parameter in both pipeline files. The task is configured to find the cobertura XML coverage files at $(Agent.TempDirectory)/**/coverage.cobertura.xml.

gfs · 2026-02-06T02:53:17Z

/azp run

azure-pipelines · 2026-02-06T02:53:29Z

Azure Pipelines successfully started running 1 pipeline(s).

Initial plan

40b7c69

Copilot AI assigned Copilot and gfs Feb 4, 2026

Copilot started work on behalf of gfs February 4, 2026 21:54 View session

Copilot AI and others added 2 commits February 4, 2026 21:58

Initial analysis

479cca3

Co-authored-by: gfs <98900+gfs@users.noreply.github.com>

Changes before error encountered

e0f18f2

Co-authored-by: gfs <98900+gfs@users.noreply.github.com>

Copilot AI requested a review from gfs February 4, 2026 22:13

Copilot started work on behalf of gfs February 4, 2026 22:29 View session

Copilot finished work on behalf of gfs February 4, 2026 22:42

gfs requested a review from Copilot February 4, 2026 23:52

Copilot started reviewing on behalf of gfs February 4, 2026 23:53 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

Copilot started work on behalf of gfs February 5, 2026 00:08 View session

Revert pipeline dotnetTestArgs to original format to fix argument par…

bdfa42c

…sing error Co-authored-by: gfs <98900+gfs@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix MSTest warnings and update pipeline test result handling~~ Fix MSTest warnings and update test code to modern patterns Feb 5, 2026

Copilot finished work on behalf of gfs February 5, 2026 00:10

Copilot started work on behalf of gfs February 5, 2026 23:09 View session

Fix test result reporting: use --logger trx with relative results dir…

1e3c7b2

…ectory Co-authored-by: gfs <98900+gfs@users.noreply.github.com>

Copilot started work on behalf of gfs February 6, 2026 01:59 View session

Fix pipeline: remove duplicate --results-directory argument

4543935

Co-authored-by: gfs <98900+gfs@users.noreply.github.com>

Copilot AI changed the title ~~Fix MSTest warnings and update test code to modern patterns~~ Migrate tests from MSTest to xUnit and clean up test infrastructure Feb 6, 2026

Copilot finished work on behalf of gfs February 6, 2026 02:01

Copilot started work on behalf of gfs February 6, 2026 02:13 View session

Copilot AI and others added 2 commits February 6, 2026 02:15

Add coverlet.runsettings for code coverage HTML report compatibility

d91b6ce

Co-authored-by: gfs <98900+gfs@users.noreply.github.com>

Merge branch 'copilot/resolve-mstest-warnings' of https://github.com/…

438c8e4

…microsoft/RecursiveExtractor into copilot/resolve-mstest-warnings

Copilot finished work on behalf of gfs February 6, 2026 02:16

gfs added 2 commits February 5, 2026 18:43

Copilot started work on behalf of gfs February 6, 2026 02:50 View session

Add PublishCodeCoverageResults@2 task via postTest parameter

fcdff49

Co-authored-by: gfs <98900+gfs@users.noreply.github.com>

Copilot finished work on behalf of gfs February 6, 2026 02:52

Conversation

Copilot AI commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Framework Migration (MSTest → xUnit)

Pipeline Updates

Code Cleanup

Uh oh!

gfs commented Feb 4, 2026

Uh oh!

Copilot AI commented Feb 4, 2026

Uh oh!

gfs commented Feb 4, 2026

Uh oh!

azure-pipelines bot commented Feb 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

gfs commented Feb 5, 2026

Uh oh!

Copilot AI commented Feb 5, 2026

Uh oh!

gfs commented Feb 5, 2026

Uh oh!

azure-pipelines bot commented Feb 5, 2026

Uh oh!

gfs commented Feb 5, 2026

Uh oh!

Copilot AI commented Feb 5, 2026

Uh oh!

Copilot AI commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gfs commented Feb 6, 2026

Uh oh!

azure-pipelines bot commented Feb 6, 2026

Uh oh!

gfs commented Feb 6, 2026

Uh oh!

Copilot AI commented Feb 6, 2026

Uh oh!

gfs commented Feb 6, 2026

Uh oh!

azure-pipelines bot commented Feb 6, 2026

Uh oh!

gfs commented Feb 6, 2026

Uh oh!

azure-pipelines bot commented Feb 6, 2026

Uh oh!

gfs commented Feb 6, 2026

Uh oh!

azure-pipelines bot commented Feb 6, 2026

Uh oh!

gfs commented Feb 6, 2026

Publish any of the code coverage results from a build.

Uh oh!

Copilot AI commented Feb 6, 2026

Publish any of the code coverage results from a build.

Uh oh!

gfs commented Feb 6, 2026

Uh oh!

azure-pipelines bot commented Feb 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Feb 4, 2026 •

edited

Loading

Copilot AI commented Feb 6, 2026 •

edited

Loading