Open
Conversation
JohnMcPMS
reviewed
Dec 17, 2025
| std::filesystem::path outputFilePath{ context.Args.GetArg(Execution::Args::Type::OutputFile) }; | ||
|
|
||
| // Check if the file exists and is hidden | ||
| DWORD attrs = std::filesystem::exists(outputFilePath) ? GetFileAttributesW(outputFilePath.c_str()) : INVALID_FILE_ATTRIBUTES; |
Member
There was a problem hiding this comment.
The exists check shouldn't be necessary; the return value from GetFileAttributesW should be INVALID_FILE_ATTRIBUTES for a non-existent file as well.
| if (isHidden) | ||
| { | ||
| // Remove hidden attribute so we can write to it | ||
| SetFileAttributesW(outputFilePath.c_str(), attrs & ~FILE_ATTRIBUTE_HIDDEN); |
Member
There was a problem hiding this comment.
I would really like it if there were a way to simply open the hidden file rather than changing the attribute. There might be a set of mode options that change the CreateFile call to avoid the documented error state (I would think specifically anything that moves to "open only existing files" might do it. So more of a if (exists) open_existing_with_truncate() else create().
If that cannot be done, then at a minimum we should use a scope exit to reset the attributes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow