Improve error message for non-existent database#218
Merged
lucas-koontz merged 2 commits intomainfrom Feb 12, 2026
Merged
Conversation
Comment on lines
173
to
177
| """ | ||
| databases = self._list_databases() | ||
| if name not in databases: | ||
| raise AttributeError("Database doesn't exist") | ||
| raise AttributeError(f"Database '{name}' doesn't exist") | ||
| return databases[name] |
There was a problem hiding this comment.
Duplicate Code:
This function Databases.get duplicates existing code.
📍 Original Location:
mindsdb_sdk/projects.py:152-161
Function: Projects.get
💡 Recommendation:
Extract this pattern into a template method in the CollectionBase parent class:
class CollectionBase:
def _get_with_validation(self, name: str, list_method, constructor, resource_type: str):
"""Template method for validated get operations"""
items = list_method()
if name not in items:
raise AttributeError(f"{resource_type} '{name}' doesn't exist")
return constructor(name, items) if callable(constructor) else items[name]Then both Databases.get() and Projects.get() can call this template method, reducing duplication and ensuring consistent error messages across all collection managers.
Consider importing and reusing the existing function instead of duplicating the logic.
MinuraPunchihewa
approved these changes
Feb 12, 2026
Contributor
MinuraPunchihewa
left a comment
There was a problem hiding this comment.
@lucas-koontz If you want to release this as a patch, you will need to update the version as well.
ea-rus
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.